Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra args and env #56

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

FrankFoerster24
Copy link
Contributor

Hi,

this allows one to inject additional arguments and environment variables to the S3 operator deployment. Main use case (for me) is to pass --useSsl=false, the environment variables are an extra convenience feature without a real use case (yet). Also: linting.

Kind regards,
Frank.

@phlg
Copy link
Contributor

phlg commented Feb 28, 2024

I am really sorry for the delay, working on the s3-operator (be it the operator itself or its Helm chart) has extremely low priority here, so we skimped checking the issues and PRs for the project.

Are you still using the project, or did you move to something else (or to your own fork) because of our lack of reply ? If per chance you are still using the chart, would you mind rebasing on top of latest master branch and bumping the chart version in Chart.yaml (to maybe next minor, so 0.3.0 0.4.0 at the time of this writing) ? If you could do that, I'll merge the PR.

Thank you for the contribution !

@phlg phlg mentioned this pull request Feb 28, 2024
@FrankFoerster24
Copy link
Contributor Author

Hi,

@phlg, no worries. We are still using it with our own branch. I've rebased, please let me know if that works for you or if you need anything else.

Best regards,
Frank.

@phlg
Copy link
Contributor

phlg commented Feb 29, 2024

That looks great, merging right now !
Thank you again for the contribution (and quick reaction time, compared to us 🥲) !

@phlg phlg merged commit 7ef8f82 into InseeFrLab:master Feb 29, 2024
@FrankFoerster24 FrankFoerster24 deleted the extra_args_and_env branch March 1, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants