Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(vscode-python) Add cacerts #161

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Conversation

titigmr
Copy link
Contributor

@titigmr titigmr commented Sep 25, 2024

Description of the change

Add certificates in vscode helm chart

Checklist

  • Chart version bumped in Chart.yaml
  • Title of the pull request follows this pattern [name_of_the_chart] Descriptive title

@titigmr titigmr force-pushed the feat/cacert branch 2 times, most recently from 241644e to 24f7b7f Compare September 25, 2024 15:14
Copy link
Contributor

@ihiverlet ihiverlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr !
A slight feedback, else it looks good

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can uncomment these values and set the same default as the values.schema.json file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can create a schema in the api and make use of the overwriteSchemaWith feature.

@titigmr titigmr requested a review from ihiverlet October 2, 2024 07:50
@ihiverlet ihiverlet merged commit 78254a5 into InseeFrLab:main Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants