Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalized startupProbe injection in all charts #153

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Generalized startupProbe injection in all charts #153

merged 5 commits into from
Sep 16, 2024

Conversation

Gaspi
Copy link
Contributor

@Gaspi Gaspi commented Sep 10, 2024

Also

  • set the liveness probe to rely on a weaker condition than the readiness probe. (6 failures with 2sec timeout vs 3 failures with 1sec timeout)
  • lowered the startup timeout to match the liveness (5sec -> 2sec) : a "started up" pod should at least be "live".

Fixes #151

@Gaspi Gaspi self-assigned this Sep 11, 2024
@Gaspi Gaspi marked this pull request as draft September 11, 2024 07:25
@Gaspi Gaspi requested a review from ihiverlet September 16, 2024 08:01
@Gaspi Gaspi marked this pull request as ready for review September 16, 2024 11:28
@ihiverlet ihiverlet merged commit 034d940 into main Sep 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihiverlet ihiverlet ihiverlet approved these changes

Assignees

@Gaspi Gaspi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Startup probe is not used on every charts
2 participants
@Gaspi @ihiverlet