Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the name of a cert-manager ClusterIssuer to acquire a certificate… #118

Merged
merged 4 commits into from
Jan 15, 2024
Merged

add the name of a cert-manager ClusterIssuer to acquire a certificate… #118

merged 4 commits into from
Jan 15, 2024

Conversation

ihiverlet
Copy link
Contributor

… for ingress

fcomte
fcomte reviewed Jan 5, 2024
View reviewed changes
charts/library-chart/templates/_ingress.tpl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we would add inject random annotations and not on the cluster issuer. what do you think @olevitt for this injection?

fcomte
fcomte requested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@fcomte fcomte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should rename : not .Values.ingress.useDefaultCertificate to .Values.ingress.useCertManager

@ihiverlet ihiverlet requested a review from fcomte January 11, 2024 19:01
@ihiverlet ihiverlet merged commit 5b2f6fb into main Jan 15, 2024
3 checks passed
@avouacr avouacr deleted the add-certManager-ClusterIssuer branch January 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcomte fcomte Awaiting requested review from fcomte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihiverlet @fcomte