Skip to content

Commit

Permalink
[Vscode-Jupyter] add custom python env variable (#181)
Browse files Browse the repository at this point in the history
  • Loading branch information
ihiverlet authored Dec 2, 2024
1 parent 30d0fba commit eeadf08
Show file tree
Hide file tree
Showing 16 changed files with 48 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/jupyter-pyspark/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.1.16
version: 2.1.17

dependencies:
- name: library-chart
Expand Down
4 changes: 4 additions & 0 deletions charts/jupyter-pyspark/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,10 @@ spec:
- name: DARK_MODE
value: "true"
{{- end }}
{{- if .Values.service.customPythonEnv }}
- name: CUSTOM_PYTHON_ENV
value: "true"
{{- end }}
envFrom:
- secretRef:
name: {{ include "library-chart.secretNameToken" . }}
Expand Down
6 changes: 6 additions & 0 deletions charts/jupyter-pyspark/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@
}
}
}
},
"customPythonEnv": {
"title": "custom python environment",
"type": "boolean",
"description": "Use a custom python environment",
"default": false
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion charts/jupyter-pyspark/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ service:
custom:
enabled: false
version: "inseefrlab/onyxia-jupyter-pyspark:py3.12.6-spark3.5.3"

customPythonEnv: false
spark:
sparkui: false
configMapName: ""
Expand Down
2 changes: 1 addition & 1 deletion charts/jupyter-python/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.1.15
version: 2.1.16

dependencies:
- name: library-chart
Expand Down
4 changes: 4 additions & 0 deletions charts/jupyter-python/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ spec:
- name: DARK_MODE
value: "true"
{{- end }}
{{- if .Values.service.customPythonEnv }}
- name: CUSTOM_PYTHON_ENV
value: "true"
{{- end }}
envFrom:
- secretRef:
name: {{ include "library-chart.secretNameToken" . }}
Expand Down
6 changes: 6 additions & 0 deletions charts/jupyter-python/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@
}
}
}
},
"customPythonEnv": {
"title": "custom python environment",
"type": "boolean",
"description": "Use a custom python environment",
"default": false
}
}
},
Expand Down
1 change: 1 addition & 0 deletions charts/jupyter-python/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ service:
custom:
enabled: false
version: "inseefrlab/onyxia-jupyter-python:py3.12.6"
customPythonEnv: false

security:
password: "changeme"
Expand Down
2 changes: 1 addition & 1 deletion charts/vscode-pyspark/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.1.17
version: 2.1.18

dependencies:
- name: library-chart
Expand Down
4 changes: 4 additions & 0 deletions charts/vscode-pyspark/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,10 @@ spec:
- name: DARK_MODE
value: "true"
{{- end }}
{{- if .Values.service.customPythonEnv }}
- name: CUSTOM_PYTHON_ENV
value: "true"
{{- end }}
envFrom:
- secretRef:
name: {{ include "library-chart.secretNameToken" . }}
Expand Down
6 changes: 6 additions & 0 deletions charts/vscode-pyspark/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@
}
}
}
},
"customPythonEnv": {
"title": "custom python environment",
"type": "boolean",
"description": "Use a custom python environment",
"default": false
}
}
},
Expand Down
1 change: 1 addition & 0 deletions charts/vscode-pyspark/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ service:
custom:
enabled: false
version: "inseefrlab/onyxia-vscode-pyspark:py3.12.6-spark3.5.3"
customPythonEnv: false

spark:
sparkui: false
Expand Down
2 changes: 1 addition & 1 deletion charts/vscode-python/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.1.16
version: 2.1.17

dependencies:
- name: library-chart
Expand Down
4 changes: 4 additions & 0 deletions charts/vscode-python/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,10 @@ spec:
- name: DARK_MODE
value: "true"
{{- end }}
{{- if .Values.service.customPythonEnv }}
- name: CUSTOM_PYTHON_ENV
value: "true"
{{- end }}
envFrom:
- secretRef:
name : {{ include "library-chart.secretNameToken" . }}
Expand Down
6 changes: 6 additions & 0 deletions charts/vscode-python/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@
}
}
}
},
"customPythonEnv": {
"title": "custom python environment",
"type": "boolean",
"description": "Use a custom python environment",
"default": false
}
}
},
Expand Down
1 change: 1 addition & 0 deletions charts/vscode-python/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ service:
custom:
enabled: false
version: "inseefrlab/onyxia-vscode-python:py3.12.6"
customPythonEnv: false

security:
password: "changeme"
Expand Down

0 comments on commit eeadf08

Please sign in to comment.