Skip to content

Commit

Permalink
Change of mind regarding the templating of extraenv values
Browse files Browse the repository at this point in the history
  • Loading branch information
Gaspi committed Oct 30, 2024
1 parent 59e1321 commit 9c6a9fa
Show file tree
Hide file tree
Showing 12 changed files with 24 additions and 18 deletions.
2 changes: 1 addition & 1 deletion charts/jupyter-pyspark/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.1.9
version: 2.1.10

dependencies:
- name: library-chart
Expand Down
5 changes: 3 additions & 2 deletions charts/jupyter-pyspark/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,9 @@ spec:
- name: DARK_MODE
value: "true"
{{- end }}
{{- with .Values.extraEnvVars }}
{{- tpl (toYaml .) $.Values | nindent 12 }}
{{- range .Values.extraEnvVars }}
- name: {{ .name }}
value: {{ tpl .value $.Values }}
{{- end }}
envFrom:
- secretRef:
Expand Down
2 changes: 1 addition & 1 deletion charts/jupyter-python/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.1.8
version: 2.1.9

dependencies:
- name: library-chart
Expand Down
5 changes: 3 additions & 2 deletions charts/jupyter-python/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,9 @@ spec:
- name: DARK_MODE
value: "true"
{{- end }}
{{- with .Values.extraEnvVars }}
{{- tpl (toYaml .) $.Values | nindent 12 }}
{{- range .Values.extraEnvVars }}
- name: {{ .name }}
value: {{ tpl .value $.Values }}
{{- end }}
envFrom:
- secretRef:
Expand Down
2 changes: 1 addition & 1 deletion charts/rstudio-sparkr/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.1.7
version: 2.1.8
dependencies:
- name: library-chart
version: 1.5.28
Expand Down
5 changes: 3 additions & 2 deletions charts/rstudio-sparkr/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,9 @@ spec:
- name: DARK_MODE
value: "true"
{{- end }}
{{- with .Values.extraEnvVars }}
{{- tpl (toYaml .) $.Values | nindent 12 }}
{{- range .Values.extraEnvVars }}
- name: {{ .name }}
value: {{ tpl .value $.Values }}
{{- end }}
envFrom:
- secretRef:
Expand Down
2 changes: 1 addition & 1 deletion charts/rstudio/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.1.5
version: 2.1.6
dependencies:
- name: library-chart
version: 1.5.28
Expand Down
5 changes: 3 additions & 2 deletions charts/rstudio/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,9 @@ spec:
- name: DARK_MODE
value: "true"
{{- end }}
{{- with .Values.extraEnvVars }}
{{- tpl (toYaml .) $.Values | nindent 12 }}
{{- range .Values.extraEnvVars }}
- name: {{ .name }}
value: {{ tpl .value $.Values }}
{{- end }}
envFrom:
{{- if .Values.s3.enabled }}
Expand Down
2 changes: 1 addition & 1 deletion charts/vscode-pyspark/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.1.10
version: 2.1.11

dependencies:
- name: library-chart
Expand Down
5 changes: 3 additions & 2 deletions charts/vscode-pyspark/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,9 @@ spec:
- name: DARK_MODE
value: "true"
{{- end }}
{{- with .Values.extraEnvVars }}
{{- tpl (toYaml .) $.Values | nindent 12 }}
{{- range .Values.extraEnvVars }}
- name: {{ .name }}
value: {{ tpl .value $.Values }}
{{- end }}
envFrom:
- secretRef:
Expand Down
2 changes: 1 addition & 1 deletion charts/vscode-python/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.1.9
version: 2.1.10

dependencies:
- name: library-chart
Expand Down
5 changes: 3 additions & 2 deletions charts/vscode-python/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,9 @@ spec:
- name: DARK_MODE
value: "true"
{{- end }}
{{- with .Values.extraEnvVars }}
{{- tpl (toYaml .) $.Values | nindent 12 }}
{{- range .Values.extraEnvVars }}
- name: {{ .name }}
value: {{ tpl .value $.Values }}
{{- end }}
envFrom:
- secretRef:
Expand Down

0 comments on commit 9c6a9fa

Please sign in to comment.