Skip to content

Commit

Permalink
enable dark mode for rstudio vscode and jupyter (#99)
Browse files Browse the repository at this point in the history
* enable dark mode for rstudio

* add user preferences for dark mode

* bump version

* add dark_mode to env

* bump version

* fix values.yaml

* fix values.yaml

* Update values.schema.json

* add darkkmode in values.schema.json

* bump version
  • Loading branch information
ihiverlet authored Oct 19, 2023
1 parent 4bb8a53 commit 155020e
Show file tree
Hide file tree
Showing 24 changed files with 143 additions and 11 deletions.
2 changes: 1 addition & 1 deletion charts/jupyter-pyspark/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.32.12
version: 1.32.14

dependencies:
- name: library-chart
Expand Down
4 changes: 4 additions & 0 deletions charts/jupyter-pyspark/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,10 @@ spec:
{{- if .Values.environment.root }}
- name: GRANT_SUDO
value: "yes"
{{- end }}
{{- if .Values.userPreferences.darkMode }}
- name: DARK_MODE
value: "true"
{{- end }}
envFrom:
- secretRef:
Expand Down
15 changes: 15 additions & 0 deletions charts/jupyter-pyspark/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,21 @@
"hidden": true,
"overwriteDefaultWith": "region.nodeSelector"
}
},
"userPreferences":{
"description": "User Preferences",
"type": "object",
"properties": {
"darkMode": {
"type": "boolean",
"description": "dark mode is or is not enabled",
"default": false,
"x-onyxia": {
"hidden": true,
"overwriteDefaultWith": "user.darkMode"
}
}
}
}
}
}
3 changes: 3 additions & 0 deletions charts/jupyter-pyspark/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -235,3 +235,6 @@ startupProbe:
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5

userPreferences:
darkMode: false
2 changes: 1 addition & 1 deletion charts/jupyter-python/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.13.7
version: 1.13.9

dependencies:
- name: library-chart
Expand Down
6 changes: 5 additions & 1 deletion charts/jupyter-python/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,11 @@ spec:
{{- if .Values.environment.root }}
- name: GRANT_SUDO
value: "yes"
{{- end }}
{{- end }}
{{- if .Values.userPreferences.darkMode }}
- name: DARK_MODE
value: "true"
{{- end }}
envFrom:
- secretRef:
name: {{ include "library-chart.secretNameToken" . }}
Expand Down
15 changes: 15 additions & 0 deletions charts/jupyter-python/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -774,6 +774,21 @@
"hidden": true,
"overwriteDefaultWith": "region.nodeSelector"
}
},
"userPreferences":{
"description": "User Preferences",
"type": "object",
"properties": {
"darkMode": {
"type": "boolean",
"description": "dark mode is or is not enabled",
"default": false,
"x-onyxia": {
"hidden": true,
"overwriteDefaultWith": "user.darkMode"
}
}
}
}
}
}
3 changes: 3 additions & 0 deletions charts/jupyter-python/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -205,3 +205,6 @@ startupProbe:
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5

userPreferences:
darkMode: false
2 changes: 1 addition & 1 deletion charts/rstudio-sparkr/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.16.4
version: 1.16.6

dependencies:
- name: library-chart
Expand Down
4 changes: 4 additions & 0 deletions charts/rstudio-sparkr/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,10 @@ spec:
- name: PERSONAL_INIT_ARGS
value: {{ .Values.init.personalInitArgs }}
{{- end }}
{{- if .Values.userPreferences.darkMode }}
- name: DARK_MODE
value: "true"
{{- end }}
envFrom:
- secretRef:
name: {{ include "library-chart.secretNameToken" . }}
Expand Down
15 changes: 15 additions & 0 deletions charts/rstudio-sparkr/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -821,6 +821,21 @@
"hidden": true,
"overwriteDefaultWith": "region.nodeSelector"
}
},
"userPreferences":{
"description": "User Preferences",
"type": "object",
"properties": {
"darkMode": {
"type": "boolean",
"description": "dark mode is or is not enabled",
"default": false,
"x-onyxia": {
"hidden": true,
"overwriteDefaultWith": "user.darkMode"
}
}
}
}
}
}
3 changes: 3 additions & 0 deletions charts/rstudio-sparkr/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -218,3 +218,6 @@ repository:
packageManagerUrl: ""
rRepository: ""
mavenRepository: ""

userPreferences:
darkMode: false
4 changes: 2 additions & 2 deletions charts/rstudio/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.15.3
version: 1.15.7

dependencies:
- name: library-chart
version: 1.5.2
version: 1.5.14
repository: https://inseefrlab.github.io/helm-charts-interactive-services
4 changes: 4 additions & 0 deletions charts/rstudio/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ spec:
- name: PERSONAL_INIT_ARGS
value: {{ .Values.init.personalInitArgs }}
{{- end }}
{{- if .Values.userPreferences.darkMode }}
- name: DARK_MODE
value: "true"
{{- end }}
envFrom:
{{- if .Values.s3.enabled }}
- secretRef:
Expand Down
15 changes: 15 additions & 0 deletions charts/rstudio/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -751,6 +751,21 @@
"hidden": true,
"overwriteDefaultWith": "region.nodeSelector"
}
},
"userPreferences":{
"description": "User Preferences",
"type": "object",
"properties": {
"darkMode": {
"type": "boolean",
"description": "dark mode is or is not enabled",
"default": false,
"x-onyxia": {
"hidden": true,
"overwriteDefaultWith": "user.darkMode"
}
}
}
}
}
}
3 changes: 3 additions & 0 deletions charts/rstudio/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,6 @@ repository:
configMapName: ""
packageManagerUrl: ""
rRepository: ""

userPreferences:
darkMode: false
2 changes: 1 addition & 1 deletion charts/vscode-pyspark/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.3.5
version: 1.3.7

dependencies:
- name: library-chart
Expand Down
6 changes: 5 additions & 1 deletion charts/vscode-pyspark/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,11 @@ spec:
{{- if .Values.environment.root }}
- name: GRANT_SUDO
value: "yes"
{{- end }}
{{- end }}
{{- if .Values.userPreferences.darkMode }}
- name: DARK_MODE
value: "true"
{{- end }}
envFrom:
- secretRef:
name: {{ include "library-chart.secretNameToken" . }}
Expand Down
15 changes: 15 additions & 0 deletions charts/vscode-pyspark/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -874,6 +874,21 @@
"hidden": true,
"overwriteDefaultWith": "region.nodeSelector"
}
},
"userPreferences":{
"description": "User Preferences",
"type": "object",
"properties": {
"darkMode": {
"type": "boolean",
"description": "dark mode is or is not enabled",
"default": false,
"x-onyxia": {
"hidden": true,
"overwriteDefaultWith": "user.darkMode"
}
}
}
}
}
}
3 changes: 3 additions & 0 deletions charts/vscode-pyspark/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -235,3 +235,6 @@ startupProbe:
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5

userPreferences:
darkMode: false
2 changes: 1 addition & 1 deletion charts/vscode-python/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.11.5
version: 1.11.7

dependencies:
- name: library-chart
Expand Down
6 changes: 5 additions & 1 deletion charts/vscode-python/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,11 @@ spec:
{{- if .Values.fauxpilot.enabled }}
- name: FAUXPILOT_SERVER
value: "{{ .Values.fauxpilot.server }}"
{{- end }}
{{- end }}
{{- if .Values.userPreferences.darkMode }}
- name: DARK_MODE
value: "true"
{{- end }}
envFrom:
- secretRef:
name : {{ include "library-chart.secretNameToken" . }}
Expand Down
17 changes: 16 additions & 1 deletion charts/vscode-python/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -800,6 +800,21 @@
"hidden": true,
"overwriteDefaultWith": "region.nodeSelector"
}
},
"userPreferences":{
"description": "User Preferences",
"type": "object",
"properties": {
"darkMode": {
"type": "boolean",
"description": "dark mode is or is not enabled",
"default": false,
"x-onyxia": {
"hidden": true,
"overwriteDefaultWith": "user.darkMode"
}
}
}
}
}
}
}
3 changes: 3 additions & 0 deletions charts/vscode-python/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -198,3 +198,6 @@ nodeSelector: {}
tolerations: []

affinity: {}

userPreferences:
darkMode: false

0 comments on commit 155020e

Please sign in to comment.