This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[feature] Adding configuration tab to tag the services through labels #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add the feature of adding a configuration tab to tag the services through labels. To achieve this functionality we added the needed values to all charts'
values.yaml
andvalues.schema.json
, while also altering the_labels.tpl
template in thelibrary-chart
. This lead us to the following solution:These tags (labels) can later be used as filters in Prometheus queries, Grafana Dashboards, and/or Kubernetes command-line tool (kubectl).
The current code still has the
library-chart
links pointing to the published chart at my repo due to testing reasons and a few missing details, such as:We suspect that this behavior is a consequence of the fact that these charts have external charts as dependencies, which makes the templates unable to attribute labels. The solution should be to have the labels attributed according to the original chart's
values.yaml
, but this makes it impossible to usetpl
functions to check whether the labels are nill or not. Some other flaws may unfold, so we were considering to let these charts with no tags (labels) configuration unless there's an easier way to solve this issue.If there is, we would appreciate a few pointers on how to do it. If there's no need for such lengths, we would prepare the code for the possible approval of this PR.