Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

[feature] Adding configuration tab to tag the services through labels #48

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dmoreira97DLTT
Copy link

This PR aims to add the feature of adding a configuration tab to tag the services through labels. To achieve this functionality we added the needed values to all charts' values.yaml and values.schema.json, while also altering the _labels.tpl template in the library-chart. This lead us to the following solution:

image

These tags (labels) can later be used as filters in Prometheus queries, Grafana Dashboards, and/or Kubernetes command-line tool (kubectl).

The current code still has the library-chart links pointing to the published chart at my repo due to testing reasons and a few missing details, such as:

  • The following charts do not get the labels specified in the configuration tab:
    • argo-cd
    • postgresql
    • argo-workflows
    • dask
    • redash
    • mongodb
    • kafka
    • fastai
    • elastic

We suspect that this behavior is a consequence of the fact that these charts have external charts as dependencies, which makes the templates unable to attribute labels. The solution should be to have the labels attributed according to the original chart's values.yaml, but this makes it impossible to use tpl functions to check whether the labels are nill or not. Some other flaws may unfold, so we were considering to let these charts with no tags (labels) configuration unless there's an easier way to solve this issue.

If there is, we would appreciate a few pointers on how to do it. If there's no need for such lengths, we would prepare the code for the possible approval of this PR.

@olevitt
Copy link
Contributor

olevitt commented Jan 18, 2022

@fcomte @avouacr you will be interested in this :)

@dmoreira97DLTT dmoreira97DLTT marked this pull request as draft January 18, 2022 17:09
@fcomte fcomte marked this pull request as ready for review January 20, 2022 12:13
@fcomte
Copy link
Contributor

fcomte commented Jan 20, 2022

It looks good to me except that the url of the library chart dependencies url is your repo and not us.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants