Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: from string to json node objects #240

Merged
merged 2 commits into from
Apr 15, 2024
Merged

fix: from string to json node objects #240

merged 2 commits into from
Apr 15, 2024

Conversation

davdarras
Copy link
Contributor

Add a stricter type for json objects (need to convert them to POJO later though)

@davdarras davdarras marked this pull request as draft April 15, 2024 12:37
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@davdarras davdarras assigned davdarras and unassigned davdarras Apr 15, 2024
@davdarras davdarras marked this pull request as ready for review April 15, 2024 12:52
@nicolasTurban nicolasTurban merged commit a0634f6 into develop Apr 15, 2024
5 checks passed
@davdarras davdarras deleted the fix/string-to-jsonnode branch May 22, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasTurban nicolasTurban nicolasTurban approved these changes

Assignees

@nicolasTurban nicolasTurban

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davdarras @nicolasTurban