Adapt workflows - Add id provider to auth - Add logout #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 31, 2024 19:04
Grafikart
requested changes
Feb 1, 2024
src/hooks/useAuth.ts
Outdated
Comment on lines
20
to
21
| const { logout } = useOidc({ assertUserLoggedIn: true }); | ||
| return logout; |
There was a problem hiding this comment.
Tu peux simplifier return useOidc({ assertUserLoggedIn: true }).logout
| @@ -5,7 +5,7 @@ const { OidcProvider, useOidc } = await createAppOidc(); | |||
|
|
|||
| export const useHasRole = (role: string): boolean => { | |||
| const { oidcTokens } = useOidc({ assertUserLoggedIn: true }); | |||
| return oidcTokens.decodedIdToken.inseegroupdefault.includes(role); | |||
| return oidcTokens.decodedIdToken.inseegroupedefaut.includes(role); | |||
There was a problem hiding this comment.
Il manque pas un d et un l là ?
There was a problem hiding this comment.
Non j'ai rectifié le nom aux endroits ou cela apparait dans l'appli, le token porte bien un vecteur "inseegroupedefaut" (écriture française)
src/hooks/useAuth.ts
Outdated
| @@ -25,7 +30,7 @@ export function useIsAuthenticated(): boolean { | |||
| } | |||
| login({ | |||
| doesCurrentHrefRequiresAuth: false, | |||
| extraQueryParams: { kc_idp_hint: "insee-ssp" }, | |||
| extraQueryParams: { kc_idp_hint: import.meta.env.VITE_IDENTITY_PROVIDER }, | |||
There was a problem hiding this comment.
Jme demande si c'est utile vu que tu l'a mis au niveau du createOidc (jte laisse vérifier)
|
Grafikart
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.