add ContactCard & FilterListToggleButton style #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenauxLeaInsee
force-pushed
the
feature/addContactList
branch
from
23e5090 to
b8c53f6
Compare
RenauxLeaInsee
force-pushed
the
feature/addContactList
branch
from
b8c53f6 to
5d5fc0e
Compare
Grafikart
requested changes
Jan 19, 2024
src/pages/FilterListBySelector.tsx
Outdated
Comment on lines
13
to
21
| <Typography | ||
| sx={{ | ||
| fontSize: "14px", | ||
| fontWeight: 400, | ||
| lineHeight: "30px", | ||
| letterSpacing: "0.15px", | ||
| color: "#797676", | ||
| }} | ||
| > |
There was a problem hiding this comment.
Utilise plutôt un style de texte déjà enregistré.
src/pages/FilterListToggleButton.tsx
Outdated
| @@ -0,0 +1,64 @@ | |||
| import ToggleButton from "@mui/material/ToggleButton"; | |||
| import ToggleButtonGroup from "@mui/material/ToggleButtonGroup"; | |||
| import React from "react"; | |||
There was a problem hiding this comment.
On évite d'importer tout React, importe plutôt ce dont tu as besoin.
src/pages/FilterListToggleButton.tsx
Outdated
Comment on lines
12
to
13
| firstOption, | ||
| secondOption, |
There was a problem hiding this comment.
On pourrait faire un tableau d'options pour prévoir le cas où on a plus de 2 éléments je pense
src/pages/FilterListToggleButton.tsx
Outdated
Comment on lines
39
to
48
| <ToggleButton | ||
| sx={{ | ||
| typography: "bodyMedium", | ||
| textTransform: "none", | ||
| fontWeight: 400, | ||
| borderRadius: "24px", | ||
| borderRightWidth: 0, | ||
| }} | ||
| value={firstOption} | ||
| > |
There was a problem hiding this comment.
Si on répète le style mivuex vaut séparer dans un composant
Comment on lines
+16
to
+25
| <Box | ||
| className="Body" | ||
| sx={{ | ||
| display: "flex", | ||
| flexDirection: "column", | ||
| alignItems: "center", | ||
| width: "100%", | ||
| height: "100%", | ||
| }} | ||
| > |
src/pages/contacts/ContactCard.tsx
Outdated
Comment on lines
60
to
76
| <Row gap={2}> | ||
| <LocationOnIcon fontSize="small" /> | ||
| <Typography variant="titleSmall">{cityName}</Typography> | ||
| </Row> | ||
| <Row gap={2}> | ||
| <LocalPhoneOutlinedIcon fontSize="small" /> | ||
| <Typography variant="titleSmall">{phone}</Typography> | ||
| </Row> | ||
| <Row gap={2}> | ||
| <EmailIcon fontSize="small" /> | ||
| <Typography variant="titleSmall">{email}</Typography> | ||
| </Row> | ||
| <Row gap={2}> | ||
| <DesktopWindowsOutlinedIcon fontSize="small" /> | ||
| <Typography variant="titleSmall">{functionContact}</Typography> | ||
| </Row> | ||
| </Stack> |
There was a problem hiding this comment.
ça passe mais quand il y a répétition ça peut être intéréssant de créer un composant dédié.
Grafikart
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.