Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: row control #851

Merged
merged 3 commits into from
Jan 16, 2024
Merged

fix: row control #851

merged 3 commits into from
Jan 16, 2024

Conversation

Grafikart
Copy link
Collaborator

@Grafikart Grafikart commented Jan 16, 2024

When compiling controls sometimes the component were already filled causing a problem with the check.

// conditionFilter = true, and we interpret undefined, that return falsy value
if (component.conditionFilter && !interpret(component.conditionFilter.value)) {
    // Skip check
}

It was true since the component was already filled.

Extra

I remove isLoopComponent external method since it was only used in this file.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@ddecrulle ddecrulle merged commit bd41cff into 2.7 Jan 16, 2024
13 of 14 checks passed
@ddecrulle ddecrulle deleted the fix/control-row branch January 16, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants