Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "headers" for table to match Lunatic model #843

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Remove "headers" for table to match Lunatic model #843

merged 1 commit into from
Jan 8, 2024

Conversation

Grafikart
Copy link
Collaborator

A simple cleaning to avoid having to support both "header" and "headers".

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ddecrulle
Copy link
Contributor

That's looks good. That affects the json generation. Did Eno is ready for this ? @BulotF @nsenave

@nsenave
Copy link
Contributor

nsenave commented Jan 8, 2024

That's looks good. That affects the json generation. Did Eno is ready for this ? @BulotF @nsenave

good to me

InseeFr/Eno#783 (comment)

@ddecrulle ddecrulle merged commit bf3ab8b into 2.7 Jan 8, 2024
14 checks passed
@ddecrulle ddecrulle deleted the chore/headers branch January 8, 2024 13:56
@ddecrulle ddecrulle mentioned this pull request Jan 18, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddecrulle ddecrulle ddecrulle approved these changes

@BulotF BulotF Awaiting requested review from BulotF

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Grafikart @ddecrulle @nsenave