Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/clamp duration #737

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Fix/clamp duration #737

merged 2 commits into from
Nov 2, 2023

Conversation

Grafikart
Copy link
Collaborator

The Duration component was already in working condition. This PR cleans the naming for CSS / stories and introduce clamping for value to ensure a valid duration.

Fix #258

@Grafikart Grafikart changed the base branch from main to 2.7 October 27, 2023 09:46
@laurentC35 laurentC35 self-requested a review November 2, 2023 08:57
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@laurentC35 laurentC35 merged commit f322a9c into 2.7 Nov 2, 2023
15 of 16 checks passed
@laurentC35 laurentC35 deleted the fix/clamp-duration branch November 2, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentC35 laurentC35 laurentC35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duration : 2 composants
2 participants
@Grafikart @laurentC35