-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTL expression readOnly
to add the readOnly attribute to a single component
#628
Conversation
… a VTL expression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il faut modifier le type dans les sources et aussi le model lunatic pour indiquer ce qui est attendu dans disabled (en plus ce n'est pas forcément présent pour tous les composants j'imagine).
Aussi, petit réflexion entre "disabled" et "readonly" car ça n'a pas la même signification niveau HTML. un champs readonly peut être focus là ou un champs disabled ne peut pas l'être. Donc à voir si le nom de la propriété correspond bien à ce que l'on veut ou si cela doit être renommé "readonly".
J'ai du mal a comprendre, je vois dans LunaticBaseProps on a déjà typé
Pour notre besoin, il s'agit bien d'un readOnly qu'on veut, une variable pre-rempli que l'on peut voir mais ne peut pas modifier. |
readOnly
to add the readOnly attribute to a single component
Verify :
|
…nseeFr/Lunatic into feat/disabled-single-component
…nseeFr/Lunatic into feat/disabled-single-component
ToDo
|
I checked these components, and the feature seems to work correctly. |
Fix : #692 ? |
SonarCloud Quality Gate failed.
|
…omponent (#628) Co-authored-by: Matthew Clark <[email protected]> Co-authored-by: Matt Clark <[email protected]> Co-authored-by: Dylan Decrulle <[email protected]> Co-authored-by: Laurent Caouissin <[email protected]>
This feature adds the possibility to define the
readOnly
attribute based on a VTL expression in the source.json.Initially, this feature has only been added to the
Input
component and theRadio
component. (note: the style of theRadio
component with the readOnly attribute has not yet been updated to communicate visually that users cannot interact with it)