fix: extraProps missing in routerlink

Fix #957
InseeFr · May 15, 2024 · 12e1d4d · 12e1d4d
1 parent 094894d
commit 12e1d4d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/src/components/shared/MDLabel/MDLabel.tsx b/src/components/shared/MDLabel/MDLabel.tsx
@@ -1,9 +1,4 @@
-import {
-	type ComponentProps,
-	Fragment,
-	type PropsWithChildren,
-	type ReactNode,
-} from 'react';
+import { Fragment, type PropsWithChildren } from 'react';
 import Markdown, { type Components } from 'react-markdown';
 import { MarkdownLink } from './MarkdownLink';
 import remarkBreaks from 'remark-breaks';

diff --git a/src/components/shared/MDLabel/MarkdownLink.tsx b/src/components/shared/MDLabel/MarkdownLink.tsx
@@ -19,13 +19,19 @@ export const MarkdownLink = slottableComponent<Props>(
 		return (
 			<>
 				{isAbsoluteLink ? (
-					<a href={href} target="_blank" rel="noopener noreferrer" id={id}>
-						{children}
-					</a>
-				) : (
 					<RouterLink to={href} id={id} {...extraProps}>
 						{children}
 					</RouterLink>
+				) : (
+					<a
+						href={href}
+						target="_blank"
+						rel="noopener noreferrer"
+						id={id}
+						{...extraProps}
+					>
+						{children}
+					</a>
 				)}
 				{tooltip && (
 					<Tooltip className="tooltip-content" id={`tooltip-${id}`}>