-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raw lunatic XML & JSON data saving into database #139
Conversation
@Id | ||
private ObjectId id; | ||
private LunaticXmlCampaign lunaticXmlData; | ||
private Mode mode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pas sûr de stocker ça en base, mais je l'ai mis au cas où
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Des remarques/propositions sur la forme
src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/domain/model/surveyunit/rawdata/LunaticJsonDataModel.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/infrastructure/adapter/LunaticJsonMongoAdapter.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
src/main/java/fr/insee/genesis/infrastructure/adapter/SurveyUnitMongoAdapter.java
Outdated
Show resolved
Hide resolved
Ah sry @alexisszmundy j'ai eu une notif sur 1fbdcc5 et pas sur le revert. My bad si les autowired sont nécessaires ici. Je fais un peu croisade contre cette annotation côté controller, mais côté service elle semble assez bien justifiée pour définir l'injection à choisir par défaut en injection de dépendance/inversion de contrôle |
Effectivement sur les controllers j'arrive à les retirer sans problème |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relu et ras
No description provided.