fix: pairwise missing variable name #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor code to make it clearer - also fix the pairwise missing response name - change linked loop to paginated loop condition - update and add javadoc, plus some comments - move some utils lunatic method outside the missing processing
|
nsenave
added a commit
that referenced
this pull request
Feb 2, 2024
* refactor: lunatic missing processing - refactor code to make it clearer - also fix the pairwise missing response name - change linked loop to paginated loop condition - update and add javadoc, plus some comments - move some utils lunatic method outside the missing processing * test(missing): update tests with paginated loop condition * test(missing): unit test for pairwise case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "response" object was put instead of its "name" value.
Also updated to condition which differentiate the behavior between main loops and linked loops for the "missing" variables: the difference shouldn't be between main vs. linked loops, but between non paginated/paginated loops.
+ refactor and add javadoc to make code clearer