Style/date format in french #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiVerriez
added
the
deploy-snapshot
|
👋 Version 3.30.1-SNAPSHOT deployed on docker hub |
github-actions
bot
removed
the
deploy-snapshot
RemiVerriez
added
the
deploy-snapshot
RemiVerriez
added
deploy-snapshot
|
👋 Version 3.30.1-SNAPSHOT.1 deployed on docker hub |
github-actions
bot
removed
the
deploy-snapshot
nsenave
reviewed
Dec 16, 2024
| @@ -158,39 +162,87 @@ private void createFormatControlsForDatepicker(Datepicker datepicker) { | |||
| // of the first control is displayed. | |||
| } | |||
|
|
|||
| private static final Logger logger = LoggerFactory.getLogger(LunaticAddControlFormat.class); | |||
There was a problem hiding this comment.
pas besoin de créer un logger il y en avait déjà un dans la classe avec l'annotation lombok @Slf4j
* refactor: dates validation and formatting * chore: modifier and typos * refactor: inner class factory and result to record * refactor: oopsies * test: unit test for iso 8601 formatter * refactor: optional instead of null * chore: fix typo in javadoc * refactor: compile year pattern only once
|
nsenave
added
the
deploy-snapshot
|
👋 Version 3.31.1-SNAPSHOT deployed on docker hub |
github-actions
bot
removed
the
deploy-snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajustement des contrôles pour que le format des dates dans les messages aux utilisateurs soit français/européen : "DD/MM/AAAA" au lieu de "AAAA-MM-DD". Le contrôle en lui-même demeure au format "AAAA-MM-DD".
Renforcement des exceptions et warnings concernant le format d'entrée des dates min et max : les formats différents de AAAA, AAAA-MM, ou AAAA-MM-JJ ne sont pas considérés. La date est alors ignorée et un "null" est retourné.