Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: solve issue when updating an existing component with a code list #894

Merged
merged 4 commits into from
Aug 22, 2024
Merged

fix: solve issue when updating an existing component with a code list #894

merged 4 commits into from
Aug 22, 2024

Conversation

EmmanuelDemey
Copy link
Collaborator

@EmmanuelDemey EmmanuelDemey commented Aug 22, 2024 •
edited
Loading

and refactor some code

  • creation of a reusable See button
  • move the structure api into the SDK package
  • Create an utility function for saving a component. (this method will manage the choice between a POST and a PUT).

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

PierreVasseur
PierreVasseur approved these changes Aug 22, 2024
View reviewed changes
src/packages/components/buttons/see.tsx Outdated
{...props}
type="button"
className="btn btn-default"
onClick={onClick}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pourquoi séparer le onClick des autres props puisqu’on ne l'utilise que là ?

@EmmanuelDemey EmmanuelDemey merged commit 61f13ee into main Aug 22, 2024
1 of 2 checks passed
@EmmanuelDemey EmmanuelDemey deleted the fix/solve-issue-component branch August 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreVasseur PierreVasseur PierreVasseur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmmanuelDemey @PierreVasseur