1135 intégrer le nouveau composant markdown sur lensemble du module jeux de données

src/packages/components/buttons/button.tsx

@@ -1,6 +1,6 @@
 import { ComponentProps, PropsWithChildren, ReactNode } from 'react';
 
-import { Link } from '../link';
+import { ExternalLink, Link } from '../link';
 import './button.css';
 
 const DEFAULT_CLASSES: string[] = [];
@@ -29,14 +29,9 @@ export const Button = ({
 	if (typeof action === 'string') {
 		if (externalLink) {
 			button = (
-				<a
-					className={className}
-					href={action}
-					rel="noopener noreferrer"
-					target="_blank"
-				>
+				<ExternalLink className={className} href={action}>
 					{content}
-				</a>
+				</ExternalLink>
 			);
 		} else {
 			button = (

src/packages/components/errors-bloc/index.tsx

@@ -54,28 +54,30 @@ export const ErrorBloc = ({ error, D }: { error?: unknown; D?: any }) => {
 
 	const errors = Array.isArray(error) ? error : [error];
 
-	const formattedErrors = errors.map((e) => {
-		let errorMsg;
-		try {
-			const parsedError =
-				e !== null && typeof e === 'object' ? e : JSON.parse(e);
+	const formattedErrors = errors
+		.filter((e) => !!e)
+		.map((e) => {
+			let errorMsg;
+			try {
+				const parsedError =
+					e !== null && typeof e === 'object' ? e : JSON.parse(e);
 
-			if (parsedError.code && D.errors[parsedError.code]) {
-				errorMsg = D.errors[parsedError.code](parsedError);
-			} else if (parsedError.message && D.errors[parsedError.message]) {
-				errorMsg = D.errors[parsedError.message](parsedError);
-			} else if (parsedError.status === 500) {
-				errorMsg = NewDictionnary.errors.serversideErrors['500'](
-					parsedError.message,
-				);
-			} else {
-				errorMsg = parsedError.message;
+				if (parsedError.code && D.errors[parsedError.code]) {
+					errorMsg = D.errors[parsedError.code](parsedError);
+				} else if (parsedError.message && D.errors[parsedError.message]) {
+					errorMsg = D.errors[parsedError.message](parsedError);
+				} else if (parsedError.status === 500) {
+					errorMsg = NewDictionnary.errors.serversideErrors['500'](
+						parsedError.message,
+					);
+				} else {
+					errorMsg = parsedError.message;
+				}
+			} catch {
+				errorMsg = e;
 			}
-		} catch {
-			errorMsg = e;
-		}
-		return errorMsg;
-	});
+			return errorMsg;
+		});
 	return (
 		<>
 			{formattedErrors.map((e, index) => (

src/packages/components/link/index.tsx

@@ -1,4 +1,8 @@
-import { ComponentProps, PropsWithChildren } from 'react';
+import {
+	ComponentProps,
+	ComponentPropsWithoutRef,
+	PropsWithChildren,
+} from 'react';
 import { Link as ReactLink } from 'react-router-dom';
 
 type LinkTypes = {
@@ -21,3 +25,14 @@ export const Link = ({
 		</ReactLink>
 	);
 };
+
+export const ExternalLink = ({
+	children,
+	...props
+}: ComponentPropsWithoutRef<'a'>) => {
+	return (
+		<a target="_blank" rel="noreferrer noopener" {...props}>
+			{children}
+		</a>
+	);
+};

src/packages/modules-classifications/visualization/general.jsx

@@ -2,6 +2,7 @@ import { Link } from 'react-router-dom';
 
 import { getDisseminationStatus } from '@components/dissemination-status/disseminationStatus';
 import { Row } from '@components/layout';
+import { ExternalLink } from '@components/link';
 import { Note } from '@components/note';
 
 import { stringToDate } from '@utils/date-utils';
@@ -151,11 +152,9 @@ const General = ({ general, secondLang }) => {
 										return (
 											<li key={fieldName}>
 												{`${mapping[fieldName]} : `}
-												<a
+												<ExternalLink
 													href={general[fieldName]}
-													target="_blank"
-													rel="noopener noreferrer"
-												>{`${general[fieldName]}`}</a>
+												>{`${general[fieldName]}`}</ExternalLink>
 											</li>
 										);
 									}

src/packages/modules-concepts/collections/home-container.spec.tsx

@@ -33,7 +33,7 @@ describe('Component', () => {
 	it('should show the loading spinner initially', () => {
 		// Simuler une promesse qui ne se résout pas immédiatement
 		CollectionApi.getCollectionList.mockImplementation(
-			() => new Promise(() => {}),
+			() => new Promise(vi.fn()),
 		);
 
 		render(<Component />);

src/packages/modules-concepts/home.spec.tsx

@@ -21,7 +21,7 @@ describe('Component (home.tsx)', () => {
 	});
 
 	it('renders the loading state initially', () => {
-		ConceptsApi.getConceptList.mockReturnValue(new Promise(() => {}));
+		ConceptsApi.getConceptList.mockReturnValue(new Promise(vi.fn()));
 
 		render(<Component />);
 

src/packages/modules-concepts/visualization/general.jsx

@@ -1,5 +1,6 @@
 import { DisseminationStatusVisualisation } from '@components/dissemination-status/disseminationStatus';
 import { Row } from '@components/layout';
+import { ExternalLink } from '@components/link';
 import { Note } from '@components/note';
 
 import { arrayToString } from '@utils/array-utils';
@@ -95,11 +96,9 @@ function ConceptGeneral({ attr, secondLang }) {
 									return (
 										<li key={fieldName}>
 											{`${mapping[fieldName]} : `}
-											<a
+											<ExternalLink
 												href={attr[fieldName]}
-												target="_blank"
-												rel="noopener noreferrer"
-											>{`${attr[fieldName]}`}</a>
+											>{`${attr[fieldName]}`}</ExternalLink>
 										</li>
 									);
 								}

src/packages/modules-concepts/visualization/links/CloseMatchLinks.spec.tsx

@@ -26,7 +26,7 @@ describe('CloseMatchLinks', () => {
 			const linkElement = screen.getByText(link.urn);
 			expect(linkElement.getAttribute('href')).toBe(link.urn);
 			expect(linkElement.getAttribute('target')).toBe('_blank');
-			expect(linkElement.getAttribute('rel')).toBe('noopener noreferrer');
+			expect(linkElement.getAttribute('rel')).toBe('noreferrer noopener');
 		});
 	});
 

src/packages/modules-concepts/visualization/links/CloseMatchLinks.tsx

@@ -1,3 +1,5 @@
+import { ExternalLink } from '@components/link';
+
 import { Link as LinkType } from '../../../model/concepts/concept';
 
 export const CloseMatchLinks = ({
@@ -11,9 +13,7 @@ export const CloseMatchLinks = ({
 				<ul>
 					{links.map((cm) => (
 						<li key={cm.urn}>
-							<a href={cm.urn} target="_blank" rel="noopener noreferrer">
-								{cm.urn}
-							</a>
+							<ExternalLink href={cm.urn}>{cm.urn}</ExternalLink>
 						</li>
 					))}
 				</ul>

src/packages/modules-datasets/datasets/edit/layout-with-lateral-menu.spec.tsx

@@ -10,10 +10,10 @@ import {
 
 describe('CollapsibleTrigger', () => {
 	it('should display the correct title based on the "opened" prop', () => {
-		render(<CollapsibleTrigger opened={true} onClick={() => {}} />);
+		render(<CollapsibleTrigger opened={true} onClick={vi.fn()} />);
 		expect(screen.getByTitle('Hide')).toBeInTheDocument();
 
-		render(<CollapsibleTrigger opened={false} onClick={() => {}} />);
+		render(<CollapsibleTrigger opened={false} onClick={vi.fn()} />);
 		expect(screen.getByTitle('Display')).toBeInTheDocument();
 	});
 

src/packages/modules-datasets/distributions/view/view-main-block.tsx

@@ -1,10 +1,12 @@
+import Editor from '@uiw/react-md-editor';
+
 import { Row } from '@components/layout';
+import { ExternalLink } from '@components/link';
 import { Note } from '@components/note';
 import { PublicationFemale } from '@components/status';
 
 import { stringToDate } from '@utils/date-utils';
 import { useSecondLang } from '@utils/hooks/second-lang';
-import { renderMarkdownElement } from '@utils/html-utils';
 
 import D, { D1, D2 } from '../../../deprecated-locales/build-dictionary';
 import { Distribution } from '../../../model/Dataset';
@@ -38,13 +40,9 @@ export const ViewMainBlock = ({
 							</li>
 							<li>
 								{D.downloadUrlTitle} :{' '}
-								<a
-									target="_blank"
-									rel="noreferrer noopener"
-									href={distribution.url}
-								>
-									{distribution.url}{' '}
-								</a>
+								<ExternalLink href={distribution.url}>
+									{distribution.url}
+								</ExternalLink>
 							</li>
 						</ul>
 					}
@@ -54,14 +52,14 @@ export const ViewMainBlock = ({
 			</Row>
 			<Row>
 				<Note
-					text={renderMarkdownElement(distribution.descriptionLg1)}
+					text={<Editor.Markdown source={distribution.descriptionLg1} />}
 					title={D1.descriptionTitle}
 					alone={!secondLang}
 					allowEmpty={true}
 				/>
 				{secondLang && (
 					<Note
-						text={renderMarkdownElement(distribution.descriptionLg1)}
+						text={<Editor.Markdown source={distribution.descriptionLg2} />}
 						title={D2.descriptionTitle}
 						alone={false}
 						allowEmpty={true}

src/packages/modules-datasets/distributions/view/view.tsx

@@ -17,7 +17,7 @@ import {
 import { ViewMenu } from './menu';
 import { ViewMainBlock } from './view-main-block';
 
-export const Component = (props) => {
+export const Component = () => {
 	const { id } = useParams<{ id: string }>();
 
 	const { data: distribution, isLoading } = useDistribution(id!);
@@ -49,7 +49,6 @@ export const Component = (props) => {
 				dataset={dataset}
 				onPublish={publish}
 				onDelete={remove}
-				{...props}
 			/>
 
 			<ErrorBloc

src/packages/modules-operations/document/edition/confirmation-modal.spec.tsx

@@ -8,8 +8,8 @@ describe('ConfirmationModal', () => {
 			<ConfirmationModal
 				isOpen={true}
 				document={{ sims: [] }}
-				onNo={() => {}}
-				onYes={() => {}}
+				onNo={vi.fn()}
+				onYes={vi.fn()}
 			/>,
 		);
 		await screen.findByText('Yes');

src/packages/modules-operations/document/visualization/home.jsx

@@ -1,6 +1,7 @@
 import { useEffect, useState } from 'react';
 
 import { Row } from '@components/layout';
+import { ExternalLink } from '@components/link';
 import { Note } from '@components/note';
 
 import { useTitle } from '@utils/hooks/useTitle';
@@ -95,13 +96,9 @@ function OperationsDocumentationVisualization({
 				<Row>
 					<Note
 						text={
-							<a
-								href={`${baseURI}/documents/document/${id}/file`}
-								rel="noopener noreferrer"
-								target="_blank"
-							>
+							<ExternalLink href={`${baseURI}/documents/document/${id}/file`}>
 								{attr.labelLg1}
-							</a>
+							</ExternalLink>
 						}
 						title={D1.titleDocument}
 						alone={true}
@@ -112,11 +109,7 @@ function OperationsDocumentationVisualization({
 			{isLink(attr) && (
 				<Row>
 					<Note
-						text={
-							<a href={attr.url} rel="noopener noreferrer" target="_blank">
-								{attr.url}
-							</a>
-						}
+						text={<ExternalLink href={attr.url}>{attr.url}</ExternalLink>}
 						title={D1.titleLink}
 						alone={true}
 						allowEmpty={true}

src/packages/modules-operations/document/visualization/home.spec.jsx

@@ -26,7 +26,7 @@ describe('OperationsDocumentationVisualization', () => {
 		const a = notes[1].querySelector('a');
 		expect(a).toBeDefined();
 		expect(a.href).toContain(document.url);
-		expect(a).toHaveAttribute('rel', 'noopener noreferrer');
+		expect(a).toHaveAttribute('rel', 'noreferrer noopener');
 		expect(a).toHaveAttribute('target', '_blank');
 		expect(a.innerHTML).toContain(document.url);
 	});

src/packages/modules-operations/families/edition/index.spec.tsx

@@ -53,7 +53,7 @@ describe('Component', () => {
 		const familyData = { id: '123', prefLabelLg1: 'Test Family' };
 		(useParams as Mock).mockReturnValue({ id: '123' });
 		(OperationsApi.getFamilyById as Mock).mockResolvedValueOnce(familyData);
-		(useGoBack as Mock).mockReturnValue(() => {});
+		(useGoBack as Mock).mockReturnValue(vi.fn());
 
 		render(<Component />);
 

src/packages/modules-operations/msd/documents/documents-bloc/document-list-item.spec.tsx

@@ -50,7 +50,7 @@ describe('DocumentLink', () => {
 			'http://example.com/documents/document/123/file',
 		);
 		expect(link.getAttribute('target')).toBe('_blank');
-		expect(link.getAttribute('rel')).toBe('noopener noreferrer');
+		expect(link.getAttribute('rel')).toBe('noreferrer noopener');
 	});
 
 	it('renders a link with document.url if it is not a document', () => {

src/packages/modules-operations/msd/documents/documents-bloc/document-list-item.tsx

@@ -1,3 +1,5 @@
+import { ExternalLink } from '@components/link';
+
 import { Document } from '../../../../model/operations/document';
 import { getLang } from '../../../../utils/dictionnary';
 import { isDocument } from '../../../document/utils';
@@ -51,13 +53,8 @@ export const DocumentLink = ({
 	const label =
 		document[`label${localPrefix}`] || document.labelLg1 || document.labelLg2;
 	return (
-		<a
-			target="_blank"
-			rel="noopener noreferrer"
-			href={uri}
-			title={document[`description${localPrefix}`]}
-		>
+		<ExternalLink href={uri} title={document[`description${localPrefix}`]}>
 			{label}
-		</a>
+		</ExternalLink>
 	);
 };

src/packages/modules-operations/msd/documents/documents-bloc/index.spec.jsx

@@ -81,7 +81,7 @@ describe('DocumentsBloc', () => {
 		const lis = container.querySelectorAll('li');
 		for (let i = 0; i < lis.length; i++) {
 			expect(lis[i].outerHTML).toEqual(
-				`<li class="list-group-item documentbloc__item"><span><a target="_blank" rel="noopener noreferrer" href="${orderedList[i].url}" title="${orderedList[i].descriptionLg1}">${orderedList[i].labelLg1}</a><i>(${orderedList[i].aside})</i></span></li>`,
+				`<li class="list-group-item documentbloc__item"><span><a target="_blank" rel="noreferrer noopener" href="${orderedList[i].url}" title="${orderedList[i].descriptionLg1}">${orderedList[i].labelLg1}</a><i>(${orderedList[i].aside})</i></span></li>`,
 			);
 		}
 	});
@@ -94,7 +94,7 @@ describe('DocumentsBloc', () => {
 		const lis = container.querySelectorAll('li');
 		for (let i = 0; i < lis.length; i++) {
 			expect(lis[i].outerHTML).toEqual(
-				`<li class="list-group-item documentbloc__item"><span><a target="_blank" rel="noopener noreferrer" href="${orderedList[i].url}" title="${orderedList[i].descriptionLg2}">${orderedList[i].labelLg2}</a><i>(${orderedList[i].aside})</i></span></li>`,
+				`<li class="list-group-item documentbloc__item"><span><a target="_blank" rel="noreferrer noopener" href="${orderedList[i].url}" title="${orderedList[i].descriptionLg2}">${orderedList[i].labelLg2}</a><i>(${orderedList[i].aside})</i></span></li>`,
 			);
 		}
 	});