Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/datasets distributions #416

Merged
merged 13 commits into from
Oct 23, 2023
Merged

Feat/datasets distributions #416

merged 13 commits into from
Oct 23, 2023

Conversation

EmmanuelDemey
Copy link
Collaborator

No description provided.

FBibonne
FBibonne reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@FBibonne FBibonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Globalement OK avec une bonne couverture de tests ;-)

Mais des remarques de forme

src/main/java/fr/insee/rmes/bauhaus_services/datasets/DatasetServiceImpl.java Outdated Show resolved Hide resolved
src/main/java/fr/insee/rmes/bauhaus_services/datasets/DatasetServiceImpl.java Outdated Show resolved Hide resolved
src/main/java/fr/insee/rmes/bauhaus_services/datasets/DatasetServiceImpl.java Outdated Show resolved Hide resolved
src/main/java/fr/insee/rmes/bauhaus_services/distribution/DistributionServiceImpl.java Outdated Show resolved Hide resolved
src/main/java/fr/insee/rmes/bauhaus_services/datasets/DatasetServiceImpl.java Outdated Show resolved Hide resolved
src/test/java/fr/insee/rmes/bauhaus_services/datasets/DatasetServiceImplTest.java Outdated Show resolved Hide resolved
src/test/java/fr/insee/rmes/bauhaus_services/distribution/DistributionQueriesTest.java Outdated Show resolved Hide resolved
src/test/java/fr/insee/rmes/bauhaus_services/distribution/DistributionServiceImplTest.java Outdated Show resolved Hide resolved
src/test/java/fr/insee/rmes/webservice/DatasetResourcesTest.java Outdated Show resolved Hide resolved
src/test/java/fr/insee/rmes/webservice/DistributionResourcesTest.java Outdated Show resolved Hide resolved
@EmmanuelDemey EmmanuelDemey mentioned this pull request Oct 20, 2023
Closed
2 tasks
@JeromeMBourgeois JeromeMBourgeois merged commit dbee4c9 into acceptance Oct 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FBibonne FBibonne FBibonne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmmanuelDemey @FBibonne @JeromeMBourgeois @PierreVasseur