Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .net standard 2.0 #10

Open
shshzi opened this issue Apr 16, 2020 · 3 comments
Open

Support for .net standard 2.0 #10

shshzi opened this issue Apr 16, 2020 · 3 comments

Comments

@shshzi
Copy link

shshzi commented Apr 16, 2020

I was wondering why the project was upgraded to .net standard 2.1 instead of staying on 2.0?
This breaks compatibility with projects that need to support .net framework.

@AlexEngblom
Copy link
Member

Might be due to stupidity of the developer :) I need to review this with better time, maybe we can go back to 2.0.

@shshzi
Copy link
Author

shshzi commented Apr 17, 2020 via email

@mrtristan
Copy link

+1 on this. we always coded around this by using all sorts of nasty pragma's to conditionally import the library and conditionally annotate things with the understanding that we'd only be able to use these json-stored types in newer code that leverages our shared layers. just actually had to remove this for that reason as we needed to come up with another approach so the old stuff could use those models too.

would rather add this back in if this is done, or maybe i'll fork and change it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants