Skip to content
This repository has been archived by the owner on Mar 20, 2021. It is now read-only.

Fixed sourcemap property - _config_dev.yml #98

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Fixed sourcemap property - _config_dev.yml #98

merged 1 commit into from
Feb 25, 2020

Conversation

dellagustin
Copy link
Contributor

When trying to run the command jekyll serve using _config_dev.yml,
it failed with the following error:

  Conversion error: Jekyll::Converters::Scss encountered an error while converting 'assets/css/atom.scss': undefined method `to_sym' for true:TrueClass Did you mean? to_s
------------------------------------------------
Jekyll 4.0.0   Please append `--trace` to the `serve` command
               for any additional information or backtrace.
------------------------------------------------

This happens because in _config_dev.yml sourcemap is set to true,
while the documentation at
https://github.com/jekyll/jekyll-sass-converter stated the allowed
values are never, always and development.

This PR fixes #93, and the issue was noticed when implementing #91.

When trying to run the command `jekyll serve` using `_config_dev.yml`,
it failed with the following error:
  Conversion error: Jekyll::Converters::Scss encountered an error while
  converting 'assets/css/atom.scss': undefined method `to_sym' for true:TrueClass Did
you mean? to_s
------------------------------------------------
Jekyll 4.0.0   Please append `--trace` to the `serve` command
               for any additional information or backtrace.
------------------------------------------------
This happens because in `_config_dev.yml` sourcemap is set to `true`,
while the documentation at
https://github.com/jekyll/jekyll-sass-converter stated the allowed
values are `never`, `always` and `development`.
Copy link
Member

@lenucksi lenucksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on the docs. Should only impact the dev environment if I read correctly?

@lenucksi lenucksi added bug Something isn't working website Things revolving around our website labels Feb 25, 2020
@dellagustin
Copy link
Contributor Author

I had to google LGTM 😄
yes, as the change is restricted to _config_dev.yml, it only affects development environment. I think the idea is to facilitate debugging of css related stuff that is generated from scss files.

If you look at https://github.com/InnerSourceCommons/innersourcecommons.org/blob/f84d08ed743f9935ef81ea7c3966d9d1e3c7ebcc/cibuild#L14 you will see that our build pipeline builds the rendered jekyll pages without explicitly providing any configuration, which means it takes into account only _config.yml, not changed by this PR.

@lenucksi
Copy link
Member

I had to google LGTM smile
yes, as the change is restricted to _config_dev.yml, it only affects development environment. I think the idea is to facilitate debugging of css related stuff that is generated from scss files.

If you look at

https://github.com/InnerSourceCommons/innersourcecommons.org/blob/f84d08ed743f9935ef81ea7c3966d9d1e3c7ebcc/cibuild#L14
you will see that our build pipeline builds the rendered jekyll pages without explicitly providing any configuration, which means it takes into account only _config.yml, not changed by this PR.

Great, this should be merged then I'd say.

@lenucksi lenucksi merged commit 34b5662 into InnerSourceCommons:master Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working website Things revolving around our website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development setup error: Jekyll::Converters::Scss - undefined method `to_sym' for true:TrueClass
2 participants