-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions are changed from default branch to version-specified. #737
Conversation
💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines. If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁
This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace. |
Thanks for this @taku333! Back when we introduced this Action it was recommended to use the version tagged Some questions about the implementation:
And last but not least, just out of curiosity: In either case, thanks a lot for identifying this issue and for helping to keep our repo stable :) |
Thanks for your reply!
I believe that if the vale-action tag is managed, upgrades below minor will be reflected automatically.
It may also be necessary to modify the vale-actions.
I am not a member of the community. I found the following book and arrived here. I am reading this to see if we can spread the InnerSource culture within the company as much as possible. |
Actually for now let's just go with your current PR. We have not really had any issues with vale-action or vale in the past, so probably your change in this PR is already making this stable enough. Thanks again for finding and fixing this! |
@taku333 one more thing: If you like, you can join our Slack. There you can find @yuhattor and other folks interested in InnerSource. There is also a channel dedicated to the InnerSource community in Japan, if that should be interesting for you. Thanks again for the contribution and the nice chat :) |
Summary
The default branch named
reviewdog
was specified, so it was changed to the version specification.It is expected to be resistant to errata-ai/vale-action changes.