Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(known-instances): Added SAP to RFC pattern #681

Merged

Conversation

dellagustin-sap
Copy link
Contributor

No description provided.

Copy link

welcome bot commented Apr 11, 2024

Thank You Banner

💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines.

If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁

  • Confirm that you have used our pattern template. Please remove any placeholder text and sections that your pattern did not need.
  • We run a number of automated checks on your PR. Please review the output of those checks on the PR itself, and see if any issues got flagged that you can fix yourself.
  • Make sure you have added your new pattern to the list of patterns in the main README.md. If you are unsure where to add your pattern, just let us know by commenting on your PR and we will help you.

This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace.

@dellagustin-sap
Copy link
Contributor Author

@michael-basil , you asked if SAP could be included as known instance, you may want to review this PR.

@dellagustin-sap
Copy link
Contributor Author

dellagustin-sap commented Apr 11, 2024

I recommend to squash this when merging, as I had to send a commit to fix a linter finding.

Copy link

@michael-basil michael-basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @dellagustin-sap - #sap 😁

@spier spier added 📖 Type - Content Work Working on contents is the main focus of this issue / PR 🐅 patterns-in-the-wild InnerSource patterns that were spotted in the wild. We can extract Known Instances and new patterns. labels Apr 11, 2024
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @dellagustin-sap. Left a suggestion inline.

Btw, is the CPA that you describe in the blog post similar to an industry body that consists of representatives of different companies to define a standard for the greater benefit of everybody involved? Wondering if the CPA is a similar idea but implemented within a single org.

@spier spier added the 2-structured Patterns with existing instances (Please see our contribution handbook for details) label Dec 11, 2024
@spier spier merged commit b470a8d into InnerSourceCommons:main Dec 11, 2024
9 checks passed
Copy link

welcome bot commented Dec 11, 2024

Congratulations Banner
Congrats on merging your first pull request! 🎉 We here at The InnerSource Commons are proud of you! 💖 Thank you so much for your contribution 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-structured Patterns with existing instances (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR 🐅 patterns-in-the-wild InnerSource patterns that were spotted in the wild. We can extract Known Instances and new patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants