-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(known-instances): Added SAP to RFC pattern #681
docs(known-instances): Added SAP to RFC pattern #681
Conversation
💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines. If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁
This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace. |
@michael-basil , you asked if SAP could be included as known instance, you may want to review this PR. |
I recommend to squash this when merging, as I had to send a commit to fix a linter finding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @dellagustin-sap - #sap 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @dellagustin-sap. Left a suggestion inline.
Btw, is the CPA that you describe in the blog post similar to an industry body that consists of representatives of different companies to define a standard for the greater benefit of everybody involved? Wondering if the CPA is a similar idea but implemented within a single org.
No description provided.