-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SAP as known instance for the 30 Day Warranty and Praise Participants patterns #672
Conversation
💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines. If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁
This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace. |
I see that your PR process does a nice modeling of praise participants! I have reviewed the contribution guidelines. Additionally, I see that all the checks have passed. I think the PR is in a good state to be reviewed at this point. I am humbly awaiting your feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michael-basil, thank you for sharing that SAP is using these patterns!
Besides sharing that you are using the patterns, it could be super helpful if you could also share a bit about how you are applying them.
As patterns have to be adapted to the specific context at the organization, it is a good illustration for other potential adopters to share more about the specifics of how this worked at SAP.
I took a look at the blog post you referenced. Here some questions that could lead to great illustrations of how applied the pattern:
- how does the praise participants approach relate to SAP's Appreciate program?
- how do you share the personalized thank you notes? written? digital?
- given SAP's size, where do you post such notes? i.e. what internal forums are helpful for saying thank you?
- for the 30 day warranty: which period did you apply? i.e. also 30 days, or something else, and why?
- are there any projects that don't need the 30 day warranty pattern? i.e. for what kind of projects is that pattern helpful, and for which ones not?
Looking forward to your feedback!
Hello @spier, Thank you for the mindful feedback. I have submitted a new version of the blog to the community.sap.com relevant community leader. This has been reviewed and approved and is available at the link below.
I attempted to channel a bit more breadth and depth with this revision after re-reviewing the 2 patterns in play here. Does this version adequately address the questions and spirit of your prompts? Also, I guess we are having a First Contribution experience?! 😁 Warmly. |
Hi @michael-basil. Yes, the examples that you added to the blog post are helpful. It is nice that you have multiple different projects that you can reference in those examples. I was originally wondering if you want to add any of this information to these patterns itself? You could think of it like a teaser in the "Known Instances" section, highlighting how and why SAP is applying these patterns and motivating readers to click through to your blog post? Maybe just something to consider for future PRs, as is doesn't to stop us from merging this PR already. Therefore I am already going ahead and merging this PR. As an aside: |
Changes are now live. e.g. see https://patterns.innersourcecommons.org/p/30-day-warranty#known-instances Nice job on your first contribution @michael-basil ! ❤️ |
Thanks @spier. Much appreciated. I was on the fence about putting the teaser or not. I could be sold either way. I may push this question internally at SAP to @dellagustin to see what he thinks. We have some ongoing dialog about exploring this pattern in further detail internally, so there may be a bit more teaser breadth and depth quality through this dialog. I really enjoyed this First Contribution experience. It is giving me some ideas internally that I am making a mental note and will percolate on. Lastly, how does one become a "member" of the InnerSource Commons GitHub Organization? And what is entailed should such a designation be granted? |
Oh, thanks for the note on the typo ... I will correct that and do one more read through. I think I found one more. |
Hi @michael-basil , if you can come up with a good teaser, that would be helpful for the readers of the pattern. .* - Depends on your expectations of what an ISPO is, which to my best knowledge is currently not very well defined. |
Recently during one of our internal SAP InnerSource focused workstream meetings I inquired about guidance for making a pull request to add SAP as a known instance for existing patterns. The conversation with @dellagustin surfaced an idea that a known instance for a pattern should have a basis for such a claim.
As such, I have captured the spirit of the value we are finding in one of my home group/departments as described in the following blog article:
I linked the article to the known instance in the proposed modified files.
Please let me know how this sits and or if there are changes desired.
Warmly.
Michael Basil 🙏 🌿