Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change either to any #668

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Conversation

jmeridth
Copy link
Contributor

In its current context, there are 3 choices so any is more appropriate. either is for binary decisions (between 2 choices).

In its current context, there are 3 choices so `any` is more
appropriate.  `either` is for binary decisions (between 2 choices).

Signed-off-by: jmeridth <[email protected]>
Copy link

welcome bot commented Mar 24, 2024

Thank You Banner

💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines.

If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁

  • Confirm that you have used our pattern template. Please remove any placeholder text and sections that your pattern did not need.
  • We run a number of automated checks on your PR. Please review the output of those checks on the PR itself, and see if any issues got flagged that you can fix yourself.
  • Make sure you have added your new pattern to the list of patterns in the main README.md. If you are unsure where to add your pattern, just let us know by commenting on your PR and we will help you.

This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace.

Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. Hope you found it easy enough to figure out how to contribute?

Many of our patterns were written by contributors that speak English as a foreign language. So I am sure there are many more language/grammar improvements like this to be made 😃

Thanks again!

@spier spier merged commit 9394132 into InnerSourceCommons:main Mar 24, 2024
9 checks passed
Copy link

welcome bot commented Mar 24, 2024

Congratulations Banner
Congrats on merging your first pull request! 🎉 We here at The InnerSource Commons are proud of you! 💖 Thank you so much for your contribution 🎁

@jmeridth jmeridth deleted the jm-grammar branch March 24, 2024 12:49
@jmeridth
Copy link
Contributor Author

@spier Yes. Contribution process was very easy. Thank you. I'm re-reading the entire patterns book again and may have other PRs. This one was the gateway PR and felt very nitpicky but thank you for merging it. Cheers.

@spier
Copy link
Member

spier commented Mar 24, 2024

That's great @jmeridth. Looking forward to any and all contributions that you want to make.

And no worry about nitpicking, if we really don't want to make a change that you are suggesting, we can just talk about that in any future PRs. No harm done, quite the opposite actually, as it is always great to have somebody with fresh eyes read our patterns again!

@spier
Copy link
Member

spier commented Mar 24, 2024

Btw your change is not live in https://patterns.innersourcecommons.org/p/common-requirements yet. Not sure how much delay we should expect there. Will confirm with the gitbook service (which is where we are hosting our book).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants