Cleanup overview of patterns in Level 1 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viewed)". Also adapt status in the patterns accordingly. Rational: by definition the 1-Initial patterns don't have a Known Instance yet, i.e. they are not proven. Therefore we don't need an extra group to state this.
…Pattern Ideas (not yet proven; brainstormed)". Those pattern are similar in quality to the ones that we already list in "### Maturity Level 1: Initial", so they don't have to be in an extra group.
…; brainstormed)" to "Maturity Level 1: Initial". Also updating the Status in the patterens themselves. Rational: * These patterns were not all that different from the ones directl in "Maturity Level 1: Initial". * Often times they don't have a solution yet, or just a brainstormed solution. * Many of them don't have a Patlet, likely because they were written at a time when the Pattern Template didn't ask for that yet
…the Donut pattern directly, rather than to the PR. Also adapted pattern slightly to fit the current Pattern template better.
spier
added
the
Type - Maintenance / Cleanup
spier
requested review from
cewilliams,
gruetter,
lenucksi,
NewMexicoKid and
nyeates
as code owners
|
I am relatively confident that this PR can get merged. |
lenucksi
approved these changes
Jan 1, 2021
gruetter
approved these changes
Jan 8, 2021
| Brainstormed pattern idea in progress | ||
|
|
||
| * Initial | ||
| * Brainstormed pattern idea in progress | ||
|
|
||
| ## Authors | ||
| * Georg Grutter |
There was a problem hiding this comment.
Since we're cleaning up: do we want to continue to mention affiliations? I can't think of a good reason, TBH.
There was a problem hiding this comment.
@gruetter what do you mean with "affiliations"? The company that the author of pattern is working for?
There was a problem hiding this comment.
I went through all other feedback and worked it in as best as I could.
Will merge the PR now but feel free to add a new issue for this related to your idea about the affiliations.
Co-authored-by: Georg Grütter <[email protected]>
Co-authored-by: Georg Grütter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Maturity Level 1: Initial we are listing various sub-groups, all stemming from review process that we used previously, before establishing the new maturity levels.
I decided to cleanup these groups, with the end result that most of them could be merged into the top-level group itself.
I only left the Donuts as a separate sub-group, as they felt distinctly different.
Please see the detailed commit messages below for my reasoning for the different cleanup steps.
Reviewing each commit one-by-one will likely be the easiest path to review this PR.
As part of this I also ported a Donut pattern from #38 in, as that way we were able to get rid of all references to PRs in the overview in
README.md.Original old sub-groups