Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ #465

Merged
merged 17 commits into from
Aug 2, 2022
Merged

FAQ #465

merged 17 commits into from
Aug 2, 2022

Conversation

tsadler1988
Copy link
Collaborator

@tsadler1988 tsadler1988 commented Jan 30, 2022

Draft Pull Request for adding an FAQ of common concerns per #455.

  • Is this a good format for a first iteration?
  • How are these questions and what other questions should we have?
  • How do we want to answer these questions? I'm happy to add answers from my point of view as a starting point, but a variety of opinions and experience would be best

This is now ready for review!

@rrrutledge
Copy link
Contributor

rrrutledge commented Jan 31, 2022

Is this a good format for a first iteration?

Looks good to me.

Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ideas.

introduction/07-faq.asciidoc Outdated Show resolved Hide resolved
introduction/07-faq.asciidoc Outdated Show resolved Hide resolved
introduction/07-faq.asciidoc Show resolved Hide resolved
introduction/07-faq.asciidoc Show resolved Hide resolved
introduction/07-faq.asciidoc Show resolved Hide resolved
introduction/07-faq.asciidoc Show resolved Hide resolved
introduction/07-faq.asciidoc Outdated Show resolved Hide resolved
@tsadler1988
Copy link
Collaborator Author

Thanks @rrrutledge added your proposed questions, split the 'overhead' question in 2, and added my thoughts to the answers threads.

Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work, Tom!

introduction/07-faq.asciidoc Outdated Show resolved Hide resolved
introduction/07-faq.asciidoc Outdated Show resolved Hide resolved
@tsadler1988 tsadler1988 marked this pull request as ready for review July 12, 2022 13:29
@tsadler1988 tsadler1988 requested a review from a team as a code owner July 12, 2022 13:29
Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one formatting change, and then this looks good.

introduction/07-faq.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!


You can mitigate this by setting expectation, potentialy via SLAs. If contributors expect PR reviews within an hour, maybe you will be stuck reviewing PRs all the time, but if you set an SLA of 1 day or 1 week, this won't be the case.

=== How do we convince management this is a good idea?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Chan:

Two recommendations:

Add link: https://innersourcecommons.org/stories/
If your organization's OSPO manages innersource projects, reach out to them for support.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrrutledge
Copy link
Contributor

Looks great, @tsadler1988 ❗️

@voongc
Copy link

voongc commented Jul 26, 2022

Cool! Thank you, both.

@tsadler1988 tsadler1988 merged commit 84a1f53 into master Aug 2, 2022
@tsadler1988 tsadler1988 deleted the common-concerns branch August 2, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants