-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tokens) add CAD, FED and JPY tokens #54
Conversation
Warning Walkthrough skippedFile diffs could not be summarized. TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- pkg/token/token_meta.json (1 hunks)
Files not summarized due to errors (1)
- pkg/token/token_meta.json: Error: Server error. Please try again later.
Additional comments not posted (2)
pkg/token/token_meta.json (2)
1921-1931
: Addition of JPY Token MetadataThe addition of the JPY token metadata looks correct. The structure follows the existing pattern, and the logo URL is correctly formatted. Please ensure the
denom
value "jpy" is confirmed by the relevant financial authority or conforms to internal standards.
1933-1943
: Addition of CAD Token MetadataThe CAD token metadata has been added correctly. The format is consistent with other entries, and the logo URL is properly included. Please verify the
denom
value "cad" as per the financial standards or internal guidelines.
We should only add base & quote denoms of spot market on this list. |
Fixes:
https://injective-labs.atlassian.net/browse/HELIX-604
https://injective-labs.atlassian.net/browse/HELIX-576
https://injective-labs.atlassian.net/browse/HELIX-497
I used the values from the latest injective lists
@ThomasRalee are we sure these denom values are correct?