Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement api function for get_vote_info #16

Merged
merged 6 commits into from
Mar 30, 2023
Merged

implement api function for get_vote_info #16

merged 6 commits into from
Mar 30, 2023

Conversation

energyGiver
Copy link
Contributor

@energyGiver energyGiver commented Mar 27, 2023 •
edited
Loading

Summary

  • implement a runtime api function to get the VoteInfo
  • chagne the VoteInfo type from StorageMap to CountedStorageMap

Describe your changes

  • implement a get_vote_info function to PoT pallet and node_template runtime.
  • design VoteInfo and get_vote_info function to bound and efficiently compute the length.
  • implement a test function when the number of selected validators has exceeded the maximum allowed limit.

Related Issue

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Well documented code
  • cargo clippy
  • cargo-nightly fmt

@energyGiver energyGiver requested a review from cocoyoon March 27, 2023 00:00
@sweatpotato13
Copy link
Contributor

@sweatpotato13 현재 master 에 바로 merge 하게 돼있는데 develop 으로 변경하려면 새로 pr 다시 해야되겟죠?

Edit으로 base branch 변경할 수 있어요

@energyGiver energyGiver changed the base branch from master to develop March 27, 2023 01:09
@energyGiver energyGiver self-assigned this Mar 27, 2023
@energyGiver energyGiver force-pushed the feature/8-implement-pot branch from 51118b8 to f751f00 Compare March 28, 2023 08:15
@energyGiver energyGiver force-pushed the feature/8-implement-pot branch from f751f00 to 0ed2a9d Compare March 28, 2023 08:21
cocoyoon
cocoyoon reviewed Mar 29, 2023
View reviewed changes
bin/node-template/runtime/src/lib.rs Outdated Show resolved Hide resolved
frame/proof-of-transaction/src/lib.rs Outdated Show resolved Hide resolved
frame/proof-of-transaction/src/lib.rs Outdated Show resolved Hide resolved
frame/proof-of-transaction/src/lib.rs Outdated Show resolved Hide resolved
frame/proof-of-transaction/src/lib.rs Outdated Show resolved Hide resolved
Cargo.lock Outdated Show resolved Hide resolved
@energyGiver energyGiver requested a review from cocoyoon March 29, 2023 07:48
@energyGiver energyGiver requested a review from cocoyoon March 29, 2023 08:46
@cocoyoon cocoyoon added enhancement New feature or request wip Work In Progress. Do Not Merge and removed wip Work In Progress. Do Not Merge labels Mar 29, 2023
sweatpotato13
sweatpotato13 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@sweatpotato13 sweatpotato13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@energyGiver energyGiver merged commit 9ce232e into develop Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweatpotato13 sweatpotato13 sweatpotato13 approved these changes

@cocoyoon cocoyoon cocoyoon approved these changes

Assignees

@energyGiver energyGiver

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@energyGiver @sweatpotato13 @cocoyoon