Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Factorise add to my drive action #1350

Merged
merged 19 commits into from
Jan 9, 2025
Merged

feat: Factorise add to my drive action #1350

merged 19 commits into from
Jan 9, 2025

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Dec 12, 2024 •
edited
Loading

  • Add the "add to my drive" action in the contextual sheet.
  • Add to my drive works in multi-select.

This small branch lives on top of the "add to my drive" branch.

@adrien-coye adrien-coye changed the base branch from master to externalLinks-famousLastFivePercent December 12, 2024 16:53
@adrien-coye adrien-coye mentioned this pull request Dec 12, 2024
Draft
7 tasks
@adrien-coye adrien-coye force-pushed the externalLinks-addToMyDriveCellAction branch from 9422c9f to abd2bae Compare December 12, 2024 17:02
@adrien-coye adrien-coye marked this pull request as ready for review December 18, 2024 12:30
@adrien-coye adrien-coye force-pushed the externalLinks-famousLastFivePercent branch from 691feee to b2f40c3 Compare December 18, 2024 13:56
@adrien-coye adrien-coye marked this pull request as draft January 7, 2025 17:33
@adrien-coye adrien-coye marked this pull request as ready for review January 8, 2025 08:08
@adrien-coye adrien-coye marked this pull request as draft January 8, 2025 09:27
@adrien-coye adrien-coye changed the title feat: Add to my drive cell action. feat: Factorise add to my drive action. Jan 8, 2025
adrien-coye
adrien-coye commented Jan 8, 2025
View reviewed changes
Copy link
Contributor Author

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some notes for the reviewer

kDrive/UI/Controller/Files/FileActionsFloatingPanelViewController+Actions.swift Show resolved Hide resolved
kDrive/UI/Controller/Files/PublicShareAction.swift Show resolved Hide resolved
kDrive/UI/Controller/Menu/Share/PublicShareViewModel.swift Show resolved Hide resolved
@adrien-coye adrien-coye marked this pull request as ready for review January 8, 2025 14:52
@PhilippeWeidmann PhilippeWeidmann changed the title feat: Factorise add to my drive action. feat: Factorise add to my drive action Jan 9, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adrien-coye adrien-coye merged commit e9abcf7 into externalLinks-famousLastFivePercent Jan 9, 2025
3 checks passed
@adrien-coye adrien-coye deleted the externalLinks-addToMyDriveCellAction branch January 9, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien-coye @PhilippeWeidmann