feat: Public share locked and expired UI #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
adrien-coye
changed the base branch from
externalLinksDownload
to
externalLinks-downloadFiles
Base automatically changed from
externalLinks-downloadFiles
to
feature-externalLinks
October 23, 2024 12:00
adrien-coye
changed the title
adrien-coye
force-pushed
the
externalLinks-lockedFolder
branch
from
490e4eb to
5fc857a
Compare
adrien-coye
force-pushed
the
externalLinks-lockedFolder
branch
from
5fc857a to
424e218
Compare
adrien-coye
commented
Oct 30, 2024
adrien-coye
changed the title
adrien-coye
force-pushed
the
externalLinks-lockedFolder
branch
from
f148fc0 to
4b0f126
Compare
adrien-coye
commented
Oct 30, 2024
kDrive/UI/Controller/Files/External/UnavaillableFolderViewController.swift
Outdated
Show resolved
Hide resolved
kDrive/UI/Controller/Files/External/UnavaillableFolderViewController.swift
Outdated
Show resolved
Hide resolved
kDrive/UI/Controller/Files/External/BaseInfoViewController.swift
Outdated
Show resolved
Hide resolved
PhilippeWeidmann
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Some general UI remarks:
- Use IKLabel with the correct style instead of .preferredFont & co
- If possible use embed this VC inside a UINavigationViewController to get the native close Button inside the navigationBar
- Spacing is incorrect compared to the figma
(As I wont be there to approve, feel free to remove my request changes after it's done)
PhilippeWeidmann
approved these changes
Nov 14, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature branch #1306