Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert JS to TS #77

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Convert JS to TS #77

merged 3 commits into from
Dec 6, 2022

Conversation

SH5H
Copy link
Contributor

@SH5H SH5H commented Dec 5, 2022

Convert JS to TS several components.

@gitguardian
Copy link

gitguardian bot commented Dec 5, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Generic Password a47decd frontend/components/utilities/attemptLogin.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Comment on lines +142 to +143
DB_USERNAME: ["user1234", "personal"],
DB_PASSWORD: ["ah8jak3hk8dhiu4dw7whxwe1l", "personal"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this kind of code has to be saved in .env file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is just dummy data :)
We populate this for every new users so that they have some secrets to play around with in their dashboard. It's not real secrets or environment variables.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitGuardian is blocking it even though it's not a real secret. Do you mind changing ah8jak3hk8dhiu4dw7whxwe1l to example_password in your branch?

This is just an example secret

Copy link
Collaborator

@vmatsiiako vmatsiiako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this contribution! I think it makes sense! :)

@vmatsiiako
Copy link
Collaborator

Actually, I'm just gonna merge, because this is a mistake on the GitGuardian side

@vmatsiiako vmatsiiako merged commit baacc31 into Infisical:main Dec 6, 2022
@SH5H SH5H deleted the jsconvert branch January 27, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants