Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circleci integration branch #298

Merged

Conversation

Aashish-Upadhyay-101
Copy link
Contributor

@Aashish-Upadhyay-101 Aashish-Upadhyay-101 commented Feb 4, 2023

Circle Ci integration. work on progress.
#91

@Aashish-Upadhyay-101 Aashish-Upadhyay-101 marked this pull request as ready for review February 8, 2023 03:43
@Aashish-Upadhyay-101 Aashish-Upadhyay-101 marked this pull request as draft February 8, 2023 03:46
@Aashish-Upadhyay-101 Aashish-Upadhyay-101 force-pushed the circleci-integration-branch branch from f49ca18 to 07c0565 Compare February 9, 2023 06:50
@Aashish-Upadhyay-101 Aashish-Upadhyay-101 marked this pull request as ready for review February 11, 2023 12:12
Copy link
Collaborator

@dangtony98 dangtony98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Some formatting stuff going on (spaces/indents and quotations) but that's because we don't enforce any formatting currently — Will look to do this soon.

@dangtony98 dangtony98 merged commit 9868476 into Infisical:main Feb 13, 2023
@Aashish-Upadhyay-101 Aashish-Upadhyay-101 deleted the circleci-integration-branch branch February 13, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants