Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): improved project creation speed #2862

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

DanielHougaard
Copy link
Contributor

Description 📣

Removed the previously necessary 2 second delay when creating projects, and instead added a forceful refetch of projects. We are already invalidating the get all projects query after creating a new project, so this seems redundant right? No. When we invalidate queries, it doesn't wait for them to invalidate. It starts the invalidation, and then redirects to the project page, which causes the UI to glitch out. To completely fix this, we do a manual refetch and await it.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

@DanielHougaard DanielHougaard self-assigned this Dec 10, 2024
Copy link
Contributor

@McPizza0 McPizza0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanielHougaard DanielHougaard merged commit 7f0d27e into main Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants