fix(Approval Workflows): Workflows keep approval history after deletion #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McPizza0
force-pushed
the
omar/eng-1555-deleting-approval-change-policy-deletes-previous-requests
branch
from
e00628d to
27721cf
Compare
McPizza0
changed the title
DanielHougaard
requested changes
Dec 8, 2024
backend/src/ee/services/access-approval-request/access-approval-request-dal.ts
Show resolved
Hide resolved
backend/src/ee/services/access-approval-request/access-approval-request-service.ts
Show resolved
Hide resolved
backend/src/ee/services/secret-approval-policy/secret-approval-policy-dal.ts
Outdated
Show resolved
Hide resolved
backend/src/ee/services/secret-approval-policy/secret-approval-policy-service.ts
Show resolved
Hide resolved
|
When an access request policy is deleted, existing access requests remain active. I think we should be deleting additional privileges associated to requests that are owned by the policy that gets deleted. |
we do this in deleteAccessApprovalPolicy |
DanielHougaard
approved these changes
Dec 9, 2024
McPizza0
deleted the
omar/eng-1555-deleting-approval-change-policy-deletes-previous-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
Before:
When you delete an approval workflow, all related requests were also deleted. This can be an issue for auditing and logging purposes
Before.mp4
Now:
When you delete a workflow; the following happens:
deletedAtdate setType ✨
Tests 🛠️
Tested manually as per videos above