Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: User/Group/Identity Modals Dropdown to Filterable Select Refactor + User Groups and Secret Tags Table Pagination #2814

Merged
merged 10 commits into from
Dec 2, 2024

Conversation

scott-ray-wilson
Copy link
Contributor

@scott-ray-wilson scott-ray-wilson commented Nov 28, 2024

Description 📣

This PR updates add/edit modals pertaining to users, identities and groups to use filterable selects over drop downs (project and org level). Minor refactoring/revisions.

Add Group to Project (All fields):
CleanShot 2024-11-28 at 09 46 01@2x

Add Users to Project (Role selection):
CleanShot 2024-11-28 at 10 09 58@2x

Invite Users to Org (Role selection):
CleanShot 2024-11-28 at 10 22 40@2x

Create/Update Identity (Role selection):
CleanShot 2024-11-28 at 11 08 52@2x

Edit User (Role Selection):
CleanShot 2024-11-28 at 11 56 46@2x

Create/Update Group (Role selection):
CleanShot 2024-11-28 at 13 14 54@2x

Secret Tags Table:
CleanShot 2024-11-28 at 14 38 08@2x

User Page Groups:
CleanShot 2024-11-28 at 14 39 53@2x

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@scott-ray-wilson scott-ray-wilson force-pushed the add-group-to-project-filterable-selects branch from 72356ed to 4c739fd Compare November 28, 2024 21:40
@scott-ray-wilson scott-ray-wilson changed the title Improvement: Various Dropdown to Filterable Select Components Improvement: User/Group/Identity Modals Dropdown to Filterable Select Refactor Nov 28, 2024
@scott-ray-wilson scott-ray-wilson marked this pull request as ready for review November 28, 2024 21:50
@scott-ray-wilson scott-ray-wilson changed the title Improvement: User/Group/Identity Modals Dropdown to Filterable Select Refactor Improvement: User/Group/Identity Modals Dropdown to Filterable Select Refactor + User Groups and Secret Tags Table Pagination Nov 28, 2024
Copy link
Contributor

@McPizza0 McPizza0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested each one - LGTM 🫡

@scott-ray-wilson scott-ray-wilson merged commit 39f7354 into main Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants