Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integration details page with logging #2429

Merged
merged 19 commits into from
Sep 17, 2024

Conversation

DanielHougaard
Copy link
Contributor

@DanielHougaard DanielHougaard commented Sep 15, 2024

Description 📣

This PR's main objective is to introduce a new integrations details page, which we're doing to bring visibility to all the integration settings. Additionally this PR also introduces integration logs, which will log integration syncs. The logs are based on our audit log system and will therefore only work if the user is on a paid plan with audit logs enabled. This is a step towards expanding our paid product line.

The PR introduces a new actor called the "Platform" actor. The platform actor is useful for when we want to perform logging on automated actions that doesn't require any user intervention (such as integration syncs!).

I've also refactored the audit logs quite a bit. You'll notice we have a new endpoint on the organization router for audit logs. This is done so we can start performing logs on an organization-level in the future. We still have the old audit log endpoint for backwards compatibility purposes, since the audit log endpoint is public.

We are still storing the integration details on the integration itself (such as lastUsed, isSynced, syncMessage). The reason for this is that we can't guarantee that the user has access to audit logs, so we can't always just compute those fields from the audit logs.

CleanShot 2024-09-15 at 20 08 35

CleanShot 2024-09-15 at 20 20 38

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@DanielHougaard DanielHougaard self-assigned this Sep 15, 2024
@DanielHougaard DanielHougaard marked this pull request as ready for review September 15, 2024 16:21
@DanielHougaard DanielHougaard changed the title Daniel/integration UI improvements feat: integration details page with logging Sep 15, 2024
Copy link
Member

@akhilmhdh akhilmhdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto

@DanielHougaard DanielHougaard merged commit 5740d2b into main Sep 17, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants