-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integration details page with logging #2429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielHougaard
changed the title
Daniel/integration UI improvements
feat: integration details page with logging
Sep 15, 2024
akhilmhdh
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfecto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR's main objective is to introduce a new integrations details page, which we're doing to bring visibility to all the integration settings. Additionally this PR also introduces integration logs, which will log integration syncs. The logs are based on our audit log system and will therefore only work if the user is on a paid plan with audit logs enabled. This is a step towards expanding our paid product line.
The PR introduces a new actor called the "Platform" actor. The platform actor is useful for when we want to perform logging on automated actions that doesn't require any user intervention (such as integration syncs!).
I've also refactored the audit logs quite a bit. You'll notice we have a new endpoint on the organization router for audit logs. This is done so we can start performing logs on an organization-level in the future. We still have the old audit log endpoint for backwards compatibility purposes, since the audit log endpoint is public.
We are still storing the integration details on the integration itself (such as lastUsed, isSynced, syncMessage). The reason for this is that we can't guarantee that the user has access to audit logs, so we can't always just compute those fields from the audit logs.
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets