Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager users without waiting for confirmation of mail #2384

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

akhilmhdh
Copy link
Member

Description 📣

This PR addresses a painpoint in which organizations has to wait for user confirmation before getting started. This will allow organization to invite users and then start assigning them to projects already. Helps smoother the automation too.

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@akhilmhdh akhilmhdh added the 🐞 bug Something isn't working label Sep 6, 2024
@akhilmhdh akhilmhdh self-assigned this Sep 6, 2024
@akhilmhdh akhilmhdh requested review from DanielHougaard and removed request for dangtony98 September 9, 2024 05:34
Copy link
Contributor

@DanielHougaard DanielHougaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super neat! Great idea to consolidate the invite logic into a single flow. Left a few smaller comments!

backend/src/lib/validator/validate-email.ts Outdated Show resolved Hide resolved
backend/src/services/auth/auth-signup-service.ts Outdated Show resolved Hide resolved
backend/src/services/auth/auth-signup-service.ts Outdated Show resolved Hide resolved
backend/src/services/auth/auth-signup-service.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@DanielHougaard DanielHougaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great work! 👏

@DanielHougaard DanielHougaard merged commit 5ad0013 into Infisical:main Sep 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants