feat(integrations): Add visibility support to Github Integration #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielHougaard
changed the title
This reverts commit 56dce67.
DanielHougaard
force-pushed
the
daniel/redirect-node-docs
branch
from
0b1eff7 to
c59a531
Compare
DanielHougaard
requested review from
akhilmhdh
and removed request for
maidul98
akhilmhdh
reviewed
Sep 3, 2024
akhilmhdh
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
Previously it wasn't possible to select the visibility type for the Github integration. It was hardcoded to
all, which is actually very misleading.allmeans it will only expose secrets to all public repositories. This means that there was no way to expose organization-scoped secrets to private repositories.This PR introduces visibility support, so the user can choose between:
Type ✨