feat(k8-operator): customizable azure auth resource url #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielHougaard
requested review from
akhilmhdh and
dangtony98
and removed request for
akhilmhdh
dangtony98
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
Previously it wasn't possible to define which resource you wanted to use when authenticating with Azure auth. With this update it's now possible to specify which resource you want to use. This is especially useful if you're using managed identities on Azure.
If no resource is defined, it'll default to
https://management.azure.com/, like it was before.I've also updated the SDK to the latest version, and added documentation that covers the new
resourcefield.Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets