Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove certain python sdk events #1367

Merged
merged 2 commits into from
Feb 4, 2024
Merged

remove certain python sdk events #1367

merged 2 commits into from
Feb 4, 2024

Conversation

vmatsiiako
Copy link
Collaborator

Description 📣

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@vmatsiiako vmatsiiako requested a review from maidul98 February 4, 2024 17:40
@@ -479,7 +479,7 @@ export const registerSecretRouter = async (server: FastifyZodProvider) => {
}
}

const shouldCapture = req.headers["user-agent"] !== "k8-operator" || shouldRecordK8Event;
const shouldCapture = (req.query.workspaceId != "650e71fbae3e6c8572f436d4") && (req.headers["user-agent"] !== "k8-operator" || shouldRecordK8Event);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to do just this workspace or did you want to do it by user agent when it is from python sdk?

@maidul98 maidul98 merged commit 5b9c043 into main Feb 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants