Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar loads incorrect data when entering a duplicate key #308

Closed
RashidUjang opened this issue Feb 7, 2023 · 2 comments
Closed

Sidebar loads incorrect data when entering a duplicate key #308

RashidUjang opened this issue Feb 7, 2023 · 2 comments
Labels
🐞 bug Something isn't working good first issue Good for newcomers help wanted Open for contributions from the community

Comments

@RashidUjang
Copy link
Contributor

Describe the bug

When trying to add a new secret, if I enter the name of a key that already exists and open the sidebar of the new secret, the sidebar content would inherit the contents of the original secret

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to the dashboard
  2. Ensure that there is an existing secret with a key, value & history
  3. Add a new secret with the same key
  4. Open the sidebar of the new key
  5. Observe that the sidebar contents matches that of the original key

Expected behavior

The sidebar should not be loaded with content from the original key

Platform you are having the issue on:

Cloud & self-hosted
@RashidUjang RashidUjang changed the title Sidebar open loads incorrect data when entering a duplicate key Sidebar loads incorrect data when entering a duplicate key Feb 7, 2023
RashidUjang added a commit to RashidUjang/infisical that referenced this issue Feb 7, 2023
@RashidUjang
fix: handle duplicate edge case for sidebar loading
a37cf91 
This changes the SideBar's data prop to be filtered by id instead of key.

fixes issue Infisical#308
@vmatsiiako vmatsiiako added 🐞 bug Something isn't working good first issue Good for newcomers help wanted Open for contributions from the community labels Feb 8, 2023
@umrak11
Copy link
Contributor

umrak11 commented Feb 22, 2023

I cannot reproduce this behaviour. Was this fixed with commit
a37cf91 ?
If not I can take this over and figure it out.

@vmatsiiako
Copy link
Collaborator

Hey @umrak11! Yes, indeed, I think this was fixed. Thank you so much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working good first issue Good for newcomers help wanted Open for contributions from the community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RashidUjang @umrak11 @vmatsiiako