fix the softdelete issue for the shared secret get by id

backend/src/services/secret-sharing/secret-sharing-dal.ts

@@ -75,18 +75,36 @@ export const secretSharingDALFactory = (db: TDbClient) => {
         tag: ""
       });
     } catch (error) {
+      console.log(error);
       throw new DatabaseError({
         error,
         name: "Soft Delete Shared Secret"
       });
     }
   };
 
+  const softDeleteByIdentifier = async (identifier: string) => {
+    try {
+      await db(TableName.SecretSharing).where({ identifier }).update({
+        encryptedValue: "",
+        iv: "",
+        tag: ""
+      });
+    } catch (error) {
+      console.log(error);
+      throw new DatabaseError({
+        error,
+        name: "Soft Delete Shared Secret By Identifier"
+      });
+    }
+  };
+
   return {
     ...sharedSecretOrm,
     countAllUserOrgSharedSecrets,
     pruneExpiredSharedSecrets,
     softDeleteById,
+    softDeleteByIdentifier,
     findActiveSharedSecrets
   };
 };

backend/src/services/secret-sharing/secret-sharing-service.ts

@@ -211,9 +211,14 @@ export const secretSharingServiceFactory = ({
 
     // all secrets pass through here, meaning we check if its expired first and then check if it needs verification
     // or can be safely sent to the client.
+
     if (expiresAt !== null && expiresAt < new Date()) {
       // check lifetime expiry
-      await secretSharingDAL.softDeleteById(sharedSecretId);
+      if (isUuidV4(sharedSecretId)) {
+        await secretSharingDAL.softDeleteById(sharedSecretId);
+      } else {
+        await secretSharingDAL.softDeleteByIdentifier(Buffer.from(sharedSecretId, "base64url").toString("hex"));
+      }
       throw new ForbiddenRequestError({
         message: "Access denied: Secret has expired by lifetime"
       });