Skip to content

Commit

Permalink
Add back passing NEXT_PUBLIC_ENV to frontend
Browse files Browse the repository at this point in the history
  • Loading branch information
Tuan Dang committed Nov 22, 2022
1 parent 094704c commit a35dedd
Show file tree
Hide file tree
Showing 6 changed files with 30 additions and 27 deletions.
15 changes: 5 additions & 10 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,14 @@ EMAIL_TOKEN_LIFETIME=
# Required
MONGO_URL=mongodb://root:example@mongo:27017/?authSource=admin

# Optional credentials for MongoDB container instance
MONGO_INITDB_ROOT_USERNAME=root
MONGO_INITDB_ROOT_PASSWORD=example

# Mongo-Express vars (needed for development only)
ME_CONFIG_MONGODB_ADMINUSERNAME=root
ME_CONFIG_MONGODB_ADMINPASSWORD=example
ME_CONFIG_MONGODB_URL=mongodb://root:example@mongo:27017/
# Optional credentials for MongoDB container instance and Mongo-Express
MONGO_USERNAME=root
MONGO_PASSWORD=example

# Website URL
# Required
NODE_ENV=development
NEXT_PUBLIC_WEBSITE_URL=http://localhost:8080
ENV=development
SITE_URL=http://localhost:8080

# Mail/SMTP
# Required to send emails
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

Thanks for taking the time to contribute! 😃 🚀

Please refer to our [Contributing Guide](https://infisical.com/docs/contributing) for instructions on how to contribute.
Please refer to our [Contributing Guide](https://infisical.com/docs/contributing/overview) for instructions on how to contribute.

We also have some 🔥amazing🔥 merch for our contributors. Please reach out to [email protected] for more info 👀
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ To quickly get started, visit our [get started guide](https://infisical.com/docs

Infisical is simple, E2EE, and (soon to be) complete.

According to one [report](https://www.ekransystem.com/en/blog/secrets-management) in 2021, only 10% of organizations use secret management solutions despite all using digital secrets to some extent.
According to a [report](https://www.ekransystem.com/en/blog/secrets-management) in 2019, only 10% of organizations use secret management solutions despite all using digital secrets to some extent.

We're on a mission to make secret management more accessible to everyone — that means building for developers, not just security teams.

Expand Down
3 changes: 3 additions & 0 deletions docker-compose.dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ services:
- /app/node_modules
command: npm run dev
env_file: .env
environment:
- NODE_ENV=${ENV}
networks:
- infisical-dev

Expand All @@ -50,6 +52,7 @@ services:
env_file: .env
environment:
- NEXT_PUBLIC_WEBSITE_URL=${SITE_URL}
- NEXT_PUBLIC_ENV=${ENV}
networks:
- infisical-dev

Expand Down
5 changes: 5 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ services:
image: infisical/backend
command: npm run start
env_file: .env
environment:
- NODE_ENV=${ENV}
networks:
- infisical

Expand All @@ -42,6 +44,9 @@ services:
dockerfile: Dockerfile.prod
image: infisical/frontend
env_file: .env
environment:
- NEXT_PUBLIC_WEBSITE_URL=${SITE_URL}
- NEXT_PUBLIC_ENV=${ENV}
networks:
- infisical

Expand Down
30 changes: 15 additions & 15 deletions docs/getting-started/features.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -46,20 +46,20 @@ Missing an integration? Throw in a request.

We're building the future of secret management, one that's comprehensive and accessible to all. Some high-level features we have in mind:

| Feature | Status |
| ------------------------------------- | ---------------- |
| Integrations | Ongoing |
| More hosting options | Ongoing |
| 1-Click Deploys | Ongoing |
| Account recovery: Backup key | Ongoing |
| Account recovery: Member-assisted | Noet yet started |
| Slack & MS teams integrations | Not yet started |
| Access logs | Not yet started |
| Version control for secrets | Not yet started |
| 2FA | Not yet started |
| Restricted IPs | Not yet started |
| Read/write access controls | Not yet started |
| Secret rotation | Not yet started |
| Comparing secrets across environments | Not yet started |
| Feature | Status |
| ------------------------------------- | --------------- |
| Integrations | Ongoing |
| More hosting options | Ongoing |
| 1-Click Deploys | Ongoing |
| Account recovery: Backup key | Ongoing |
| Account recovery: Member-assisted | Not yet started |
| Slack & MS teams integrations | Not yet started |
| Access logs | Not yet started |
| Version control for secrets | Not yet started |
| 2FA | Not yet started |
| Restricted IPs | Not yet started |
| Read/write access controls | Not yet started |
| Secret rotation | Not yet started |
| Comparing secrets across environments | Not yet started |

Interested in contributing? Check out the guide.

0 comments on commit a35dedd

Please sign in to comment.