Remove alias from user settings. (matomo-org#13543)

* Remove alias from user settings. * Update UI test screenshot.
InfinityVoid · Oct 11, 2018 · 82dde8f · 82dde8f
1 parent 4ccd8b1
commit 82dde8f
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 13 deletions.
diff --git a/plugins/UsersManager/Controller.php b/plugins/UsersManager/Controller.php
@@ -172,7 +172,6 @@ public function userSettings()
 
         $userLogin = Piwik::getCurrentUserLogin();
         $user = Request::processRequest('UsersManager.getUser', array('userLogin' => $userLogin));
-        $view->userAlias = $user['alias'];
         $view->userEmail = $user['email'];
         $view->userTokenAuth = Piwik::getCurrentUserTokenAuth();
 
@@ -414,7 +413,6 @@ private function noAdminAccessToWebsite($idSiteSelected, $defaultReportSiteName,
 
     private function processPasswordChange($userLogin)
     {
-        $alias = Common::getRequestVar('alias');
         $email = Common::getRequestVar('email');
         $newPassword = false;
 
@@ -440,7 +438,6 @@ private function processPasswordChange($userLogin)
             'userLogin' => $userLogin,
             'password' => $newPassword,
             'email' => $email,
-            'alias' => $alias,
         ], $default = []);
 
         if ($newPassword !== false) {

diff --git a/plugins/UsersManager/angularjs/personal-settings/personal-settings.controller.js b/plugins/UsersManager/angularjs/personal-settings/personal-settings.controller.js
@@ -57,7 +57,6 @@
         this.save = function () {
 
             var postParams = {
-                alias: this.alias,
                 email: this.email,
                 defaultReport: this.defaultReport == 'MultiSites' ? this.defaultReport : this.site.id,
                 defaultDate: this.defaultDate,

diff --git a/plugins/UsersManager/templates/userSettings.twig b/plugins/UsersManager/templates/userSettings.twig
@@ -20,13 +20,6 @@
              inline-help="{{ 'UsersManager_YourUsernameCannotBeChanged'|translate|e('html_attr') }}">
         </div>
 
-        <div piwik-field uicontrol="text" name="alias"
-             ng-model="personalSettings.alias"
-             maxlength="45"
-             title="{{ 'UsersManager_Alias'|translate|e('html_attr') }}"
-             value="{{ userAlias|raw }}">
-        </div>
-
         <div piwik-field uicontrol="text" name="email"
              ng-model="personalSettings.email"
              maxlength="100"

diff --git a/tests/UI/expected-screenshots/UIIntegrationTest_admin_user_settings.png b/tests/UI/expected-screenshots/UIIntegrationTest_admin_user_settings.png