don't allow SEO plugin to make non-HTTPS requests (matomo-org#13575)

InfinityVoid · Oct 11, 2018 · 31061b7 · 31061b7
1 parent 5837a7e
commit 31061b7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/plugins/SEO/Metric/Alexa.php b/plugins/SEO/Metric/Alexa.php
@@ -17,8 +17,8 @@
  */
 class Alexa implements MetricsProvider
 {
-    const URL = 'http://data.alexa.com/data?cli=10&url=';
-    const LINK = 'http://www.alexa.com/siteinfo/';
+    const URL = 'https://data.alexa.com/data?cli=10&url=';
+    const LINK = 'https://www.alexa.com/siteinfo/';
 
     /**
      * @var LoggerInterface

diff --git a/plugins/SEO/Metric/Bing.php b/plugins/SEO/Metric/Bing.php
@@ -17,7 +17,7 @@
  */
 class Bing implements MetricsProvider
 {
-    const URL = 'http://www.bing.com/search?setlang=en-US&rdr=1&q=site%3A';
+    const URL = 'https://www.bing.com/search?setlang=en-US&rdr=1&q=site%3A';
 
     /**
      * @var LoggerInterface

diff --git a/plugins/SEO/Metric/DomainAge.php b/plugins/SEO/Metric/DomainAge.php
@@ -130,12 +130,6 @@ private function getUrl($url)
     {
         try {
             return $this->getHttpResponse($url);
-        } catch (\Exception $e) {
-        }
-
-        $httpUrl = str_replace('https://', 'http://', $url);
-        try {
-            return $this->getHttpResponse($httpUrl);
         } catch (\Exception $e) {
             $this->logger->warning('Error while getting SEO stats (domain age): {message}', array('message' => $e->getMessage()));
             return '';