electron: Tab order in node editor

[rdominick]

If you hit TAB from the tags line on the node editor, the focus goes nowhere, It should send the cursor to the node body.

If you hit TAB many times from the tags line, it eventually puts focus on the node name. The editor is never selected.

[blurymind]

that is actually a missing feature :)
Pull requests to add it are welcome

[rdominick]

Since this is the way it worked before the toolbar, it's more of a bug, don't you think? :)

[blurymind]

I think what happens is that all the buttons are now taking focus in the order, which is natural when there is now a new element there

[rdominick]

Traditionally, in a UI with a toolbar, the toolbar buttons are not selectable via keyboard -- those buttons are shortcuts for menu items which have their own keyboard shortcuts.

If the toolbar buttons are getting focus than there is no visual feedback of that fact. You can trigger the current toolbar button with the spacebar, but the results are... unpredictable

Also, the node body is now never tabbed to/selected, even though it is still an element that should naturally have a place in the tab order.

I'm not arguing just to argue; I honestly want the UI to be as good as it can be. This is a major usability issue for users like me who don't like to take their hands off the keyboard once they start typing.

[blurymind]

fixed via dc6588e
and 37a3e6f

please confirm if that works for you :)
tabbing from tags will now always tab to editor

[rdominick]

Yes, it works quite well.

[blurymind]

In that case let's close this issue :)

[rdominick]

Actually, I did find an issue while I was messing around: since the focus is triggered on blur, if you shift-tab away from the tags line it tabs forward to the editor instead...

[blurymind]

Actually, I did find an issue while I was messing around: since the focus is triggered on blur, if you shift-tab away from the tags line it tabs forward to the editor instead...

I fixed this properly now. Will do the commit tonight :)

[blurymind]

should be fixed now, try again :)

via
c54dd56